Bug#675701: ptop

[Bas van den Dikkenberg <bas@dikkenberg.net>]

Hi bart,

-----Oorspronkelijk bericht-----
Van: Bart Martens [mailto:bartm@master.debian.org] Namens Bart Martens
Verzonden: maandag 4 juni 2012 19:35
Aan: Bas van den Dikkenberg
CC: 675701@bugs.debian.org; Barry deFreese
Onderwerp: RFS: ptop

Hi Bas,

I suggested earlier to have another look at the list of architectures for these reasons :

- m68k is twice on the list,

Oke removed one

- hppa is not on the list but removing hppa is not mentioned in debian/changelog,
Added to changelog
- powerpcspe is on the list but the build fails for the same reason as hppa.
Removed from control and added to changelog
Architecture: amd64 armel armhf i386 ia64 mips mipsel powerpc s390 s390x sparc sparc64 sh4 ppc64 powerpcspe m68k m68k armhf alpha hurd-i386

There are some typing mistakes in debian/changelog.

 | ptop (3.6.2-8) unstable; urgency=low
 | 
 |   * Applyed path for hurd architechtur and activate in control file (closes: #675757)
 |
 |  -- Bastiaan Franciscus van den Dikkenberg <bas@dikkenberg.net>  Mon, 04 Jun 2012 12:50:35 +0200  |  | ptop (3.6.2-7) unstable; urgency=low  | 
 |   * Remove architechtures hurd-i386, kfreebsd-amd64 and kfreebsd-i386
 |     because they alway fail
 |   * Changed Standards-Version to 3.9.3
 |
 |  -- Bastiaan Franciscus van den Dikkenberg <bas@dikkenberg.net>  Sat, 02 Jun 2012 21:13:20 +0200

corrected

It would be nice to have 3.6.2-7 and 3.6.2-8 combined into only 3.6.2-7, but it's not really an error.

Done

It is good to see that hurd-i386 is back.  I guess you don't have a solution for the other removed architectures yet.

DOne

I see that debian/patches/ptop_hurd contains machine/m_gnu.c and that file contains this:


 * AUTHOR: Richard Henderson <rth@tamu.edu>
 * Order support added by Alexey Klimkin <kad@klon.tme.mcst.ru>
 * Ported to 2.4 by William LeFebvre

But I don't find any Henderson in debian/copyright.  I also don't see any license for machine/m_gnu.c.  Maybe Barry deFreese knows more, since he is mentioned in the patch as the author of the patch.

After doing a diff with machine/m_linux.c these files are the same but this the fix to let it work on hurd.

I just uploaded the new version to mentors