Bug#673096: RFS: figlet/2.2.4-1

[Jonathan McCrohan <jmccrohan@gmail.com>]

[I've uploaded a new version 2.2.4-1 [1] to mentors.d.o]

On 23/05/12 18:33, Jakub Wilk wrote:
> * Jonathan McCrohan <jmccrohan@gmail.com>, 2012-05-16, 00:27:
> .diff.gz of the previous package touches some upstream files. What
> happened to this delta? (This should be documented in the changelog.)

I've re-added it now, and added a changelog entry.
 
> I see you added makefile_set_debian_paths.patch, but this is not
> mentioned in the changelog.

This is documented in the changelog now.

> What's up with figlist_man_hyphen-used-as-minus-sign.patch? It's not
> listed in debian/patches/series.

I've fixed this, and removed the now useless override.

>>    - Update debian/copyright (closes: #436302)
> 
> You need to indent the enumerated list by an extra space. (Or
> alternatively: make all lines of the list indented by exactly one space,
> and then add (escaped) empty lines between the points.)

I've indented these.

>>    - Fix moolets bashism (closes: #530082)
> 
> You introduced a dashism instead... Oh, and it you are at fixing this,
> please also fix the security hole (insecure creation of temporary files).

Fixed.

>>    - Move figlet manpage to alternatives system (closes: 403665)
> 
> I'd add a # here, for consistency with the other "closes" lines.

Fixed.
 
> Shouldn't you use --slave here?

Yes, slave would be neater alright. I've switched to that.

>>    - Add watchfile
> 
> Does ftp.figlet.org support only passive mode? (That would be very odd.) If
> this is not the case, I would not put "opts=pasv" in debian/watch.

Yes, it only supports passive, hence "opts=pasv".

>>    - Remove references to depreciated figfonts(-cjk) packages
> 
> s/depreciated/deprecated/ maybe?

Fixed.

Jon

[1]
figlet (2.2.4-1) unstable; urgency=low

  * New upstream release. (closes: #617422)
    - Relicensed as BSD; figlet can move back to main \o/
    - New upstream makefile does not support variables from d/rule; Added
      makefile_set_debian_{buildflags,paths}.patch accordingly.
  * Improve packaging
    - Update S-V to 3.9.3
    - Bump Debhelper to v9
    - Switch to dpkg-source 3.0 (quilt) format (Closes: #672320)
      - Added 2.2.2-1 delta as fix-chkfont-coredump.patch
    - Switch to dh-style debian/rules
    - Various lintian fixes
    - Update package description (closes: #557254)
    - Update debian/copyright (closes: #436302)
    - Fix moolets bashism (closes: #530082)
    - Move figlet manpage to alternatives system (closes: #403665)
    - Add watchfile
    - Add Homepage to debian/control
    - Remove references to deprecated figfonts(-cjk) packages
    - Remove local copies of man pages (merged upstream)
  * Add myself as co-maintainer

 -- Jonathan McCrohan <jmccrohan@gmail.com>  Mon, 28 May 2012 01:07:24 +0100