Hi Mike, On Mon, 7 May 2012 01:01:37 +0200, Stephen Kitt <steve@sk2.org> wrote: > On Sun, May 06, 2012 at 06:04:17PM -0400, Michael Gilbert wrote: > > I just reviewed this package. It looks good except for a couple issues: > > Thanks for taking a look at this. > > > 1. bin/credits.rpl seems to be a binary file in the repacked upstream > > source (there may be others, but I stopped at that one) > > Apart from the various .ogg files and the .ttf files for DejaVu, > that's the only binary left. It's a replay of a level in the game, so > there is no appropriate form for modification - it was recorded using > the game and is not generated... > > > 2. I'm not sure that it's good practice to apply the patch directly > > within the upstream orig file. It would be better to do that via > > quilt. You probably did that to make sure that the orig would be > > buildable by itself, but that isn't necessary. > > That is indeed why I did it. I'll fix it once I get wine-gecko done! I've uploaded a fixed package to http://mentors.debian.net/package/xmoto and pushed the changes to the svn repository: * I've repacked the tarball, the only change now is the removal of glext.h; I left the added files in the bin folder out since they can be reconstructed byte-for-byte using "xmoto --unpack" (and I've added a README.source explaining this); * the patch required to build as a result of removing glext.h is now applied as a Debian patch; * I added DMUA as you suggested. Regards, Stephen
Attachment:
signature.asc
Description: PGP signature