[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#669720: review of reviewboard_1.7~git20120425+dfsg-1.dsc



Hi Dmitry,

a few comments:

- neither debian/README.Source nor debian/changelog tells me on which git 
commit this is based exactly. There have been several commits on April 25th...

- README.Source further states: "Unfortunately ReviewBoard itself requires 
JQuery-UI version 1.6 which is not in debian. That's why we ship own copy of 
this library." - while http://packages.qa.debian.org/j/jqueryui.html tells me 
there is 1.8 even in stable. Please drop the embedded code copy!

- same for jquery

- s/mare/are/ typo in README.Source.

- I think it would be cool if you could run "debian/rules get-git-snapshot-
source" with an optional parameter, specifying the git commit id to be 
fetched.


So much for now.


cheers,
	Holger



Reply to: