tags 672394 + moreinfo owner 672394 ! thanks Hi Neutrom, this is a review of your package ipset. * Do not set "DM-Upload-Allowed: yes" on your own. It's your sponsor's domain to do so. It's hard enough to find sponsors as is, no need to scare off even more potential sponsors by adding DMUA for packages which show up on debian-mentors without prior agreement. * You declare the debhelper compat[ibility] to be 9, but you build depend on "debhelper (>= 9)". Please use a version which actually supports the finalized level 9. That is 9.20120115. * Do not start with uppercase characters in libipset-dev's description. You did it correctly for the other binary package, though. * Why do you use dh_autoreconf? You do not patch automake stuff and a brief test seems to confirm it is not needed. * Are you sure about the location of the binary in the file system? iptables is in /sbin, why do you install ipset to /usr/sbin? I am willing to sponsor your package if you fix the fist two concerns at very least. -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D
Attachment:
signature.asc
Description: OpenPGP digital signature