[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#671701: RFS: autofs/5.0.6-1 [ITA] -- kernel-based automounter for Linux



> There's one more issue with the new package.  I already
> told Ian about it, but apparently he ignored it.  This
> new code being added as a patch to debian package,
> originally from upstream author:
> 
> ++static inline unsigned int linux_version_code(void)
> ++{
> ++        struct utsname my_utsname;
> ++        unsigned int p, q, r;
> ++
> ++        if (uname(&my_utsname))
> ++                return 0;
> ++
> ++        p = (unsigned int)atoi(strtok(my_utsname.release, "."));
> ++        q = (unsigned int)atoi(strtok(NULL, "."));
> ++        r = (unsigned int)atoi(strtok(NULL, "."));
> ++        return KERNEL_VERSION(p, q, r);
> ++}
> 
> This will break with 2-number kernel version string.  There
> were several tools who assumed 3-component version string
> and who broke when 3.0-rc come out, so Linus decided to
> postprone defaulting to 2-component version.  Many packages
> has been fixed since, but here autofs introduces a new bug
> of the same theme.
> 
> Note that actually the version check isn't really necessary
> since the issue for which it has been added is now resolved
> in the kernel.
> 
> Thanks,
> 
> /mjt

I'm not sure if I fully understand the implications...
As far as I know it works well with 3.2 kernel...
Any suggestions are welcome.

By the way, many thanks to you for your work on 'mdadm' package.
I'm in your debt for this. 
Eventually I might be available for help but you're doing great already. :)

Cheers,
Dmitry.



Reply to: