Bug#671701: RFS: autofs/5.0.6-1 [ITA] -- kernel-based automounter for Linux
On 06.05.2012 09:21, Michael Tokarev wrote:
> On 06.05.2012 09:01, Michael Tokarev wrote:
>> On 06.05.2012 07:14, Dmitry Smirnov wrote:
>>> Package: sponsorship-requests
>>> Severity: normal
>>>
>>> Dear mentors,
>>>
>>> I am looking for a sponsor for package "autofs"
>>>
>>> * Package name : autofs
>>> Version : 5.0.6-1
>
>
> There's one more issue with the new package. I already
> told Ian about it, but apparently he ignored it. This
> new code being added as a patch to debian package,
> originally from upstream author:
>
> ++static inline unsigned int linux_version_code(void)
> ++{
> ++ struct utsname my_utsname;
> ++ unsigned int p, q, r;
> ++
> ++ if (uname(&my_utsname))
> ++ return 0;
> ++
> ++ p = (unsigned int)atoi(strtok(my_utsname.release, "."));
> ++ q = (unsigned int)atoi(strtok(NULL, "."));
> ++ r = (unsigned int)atoi(strtok(NULL, "."));
> ++ return KERNEL_VERSION(p, q, r);
> ++}
>
> This will break with 2-number kernel version string. There
> were several tools who assumed 3-component version string
> and who broke when 3.0-rc come out, so Linus decided to
> postprone defaulting to 2-component version. Many packages
> has been fixed since, but here autofs introduces a new bug
> of the same theme.
>
> Note that actually the version check isn't really necessary
> since the issue for which it has been added is now resolved
> in the kernel.
And note that whole 5.0.6-allow-for-kernel-packet-size-change.patch
is NOT NEEDED, it should be reverted upstream. *SIGH*, we spent
a ton of time and emails discussing this matter, please find
the recent LWN feature article about it (a good summary), or
LKML threads. The patches are now added to all stable trees.
The two patches -- linux kernel version check and this one --
should be reverted upstream and not included in debian package.
Thanks,
/mjt
Reply to: