Bug#693330: RFS: mathjax/2.1+20121028-1 mathjax-docs/2.1+20121030-1
Hi Andrew, thanks for your review.
On Mon, Dec 17, 2012 at 5:16 AM, Andrew Starr-Bochicchio <asb@debian.org> wrote:
> 1) The debian/watch file doesn't seem to find any releases:
>
> $ uscan --report --verbose
> -- Scanning for watchfiles in .
> -- Found watchfile in ./debian
> -- In debian/watch, processing watchfile line:
> opts=filenamemangle=s/.*v(.*)/mathjax_$1.orig.tar.gz/
> http://github.com/mathjax/MathJax/tags .*/tarball/v(.*)
> uscan warning: In debian/watch,
> no matching hrefs for watch line
> http://github.com/mathjax/MathJax/tags .*/tarball/v(.*)
> -- Scan finished
>
> According to the PTS, a working one can be found here:
>
> http://qa.debian.org/cgi-bin/watchfile.cgi?package=mathjax
Fixed another way. The watch file doesn't find new 2.1 release anyway
because upstream didn't tag it :(
> 2) The debian/copyright file has a few small issues with the spec.
>
> - SIL Open Font License (OFL), Version 1.1. should just use the short
> name OFL-1.1 in the License field.
>
> - As it isn't among the common-licenses, you need to include the full
> text of the OFL-1.1.
>
> - Optionally, you can use stand-alone license paragraphs for a given
> license once, instead of repeating it in each Files paragraph that
> refers to it. Also, you could combine the Files paragraphs for the
> files that share the same license and copyright holder. I.e.
>
> Files: fonts/HTML-CSS/TeX/eot
> fonts/HTML-CSS/TeX/otf
Added full license text (about 100 lines...). I don't think I can use
the short name as it is not listed in the specification:
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name.
Also I've added stand-alone header for Apache license.
> 3) Speaking of fonts... Are they useful outside of MathJax? If so, you
> might want to consider putting them into a separate package and
> installing them system-wide.
The fonts are just TeX fonts in different format, I don't think they
would be useful outside MathJax.
I know it would be a good idea to rebuild the fonts from source, but
(a) some of the dependencies needed for build are not available in
Debian and (b) the build scripts aren't provided in Git repository (so
I'll have put them in debian tarball like I already do with JS
compressing scripts).
> 4) Might it make more sense to revert the original compressed files in
> the clean target rather than the install one?
I don't like when after build some of the upstream files are missing
(renamed in this case). Also, that would require some additional
checks to make it possible to run clean twice.
> But all that's a bit nit-picky. Now lets look at the doc package:
>
> 1) Again, in debian/copyright you could optionally clean it up a bit
> by using stand-alone license paragraphs.
Done.
> 2) In debian/control, you have:
>
> Maintainer: Dmitry Shachnev <mitya57@gmail.com>
> Uploaders: Debian Javascript Maintainers
> <pkg-javascript-devel@lists.alioth.debian.org>
>
> In the mathjax source package, you have the reverse, the team is the
> maintainer and you're the uploader. I don't know if the pkg-javascript
> team has a policy on which is right or not, but it seems to me that it
> should at least be consistent.
Have set myself as Maintainer for mathjax, thanks for noticing the
inconsistence.
> 3) You have no debian/watch file.
The docs repository doesn't have any tags at all (I guess it's
supposed to be a "rolling" branch), so no watch file for now.
> 4) Even though AFAIK you don't need an ITP for this, it would make
> sense to mention in the changelog entry that you are splitting this
> off of the main package. That way the ftp-masters don't need to spend
> time figuring out why it doesn't close an ITP.
Done.
> Again, mostly nitpicking... I'd be happy to upload both packages after
> the watch files are fixed/provided. Everything else can just be
> considered for a future upload.
>
> Thanks!
Thank *you*.
I have updated the git branches and uploaded updated packages to
mentors.debian.net. The new URLs are (dget'able):
http://mentors.debian.net/debian/pool/main/m/mathjax-docs/mathjax-docs_2.1+20121206-1.dsc
http://mentors.debian.net/debian/pool/main/m/mathjax/mathjax_2.1+20121028-1.dsc
There were some errors when I was uploading the second package, so in
case it's broken, here's an alternative link:
http://people.ubuntu.com/~mitya57/mathjax/mathjax_2.1+20121028-1.dsc
(I've also used a newer snapshot for -docs).
--
Dmitry Shachnev
Reply to: