[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#694940: RFS: toped/0.9.8.1-r2211-1 [ITP]



I don't intend to sponsor this package but here is a review.

If you are contacting upstream as a result of this review, please
point them at our upstream guide:

http://wiki.debian.org/UpstreamGuide

This package is not suitable for Debian main yet, here are the blockers:

tpd_common/glf.* have a non-free license preventing commercial use.
Upstream needs to contact the copyright holder (Romka Graphics) and
get them to change it to GPL or these files need to be removed.

tll/user_functions/tools/logos/examples/README suggests that
tiger.pnm.gz and wnf_logo.pnm.gz are non-free and thus need to be
removed since the author is unknown.

fonts/*.glf look like they are derived from non-free fonts from
Microsoft Windows and other places. Please ask upstream to remove them
and switch to using the fonts already installed on the system.
Something like pango or quesoglc can be used to render to OpenGL from
system fonts.

debian/copyright does not document the copyright and license
information for all upstream files.

The package fails to build from source in pbuilder/cowbuilder (missing
build-dep on zlib):

checking for gzsetparams in -lz... no
configure: error: zlib library not found

The following are things that would be nice to fix:

tpd_common/avl.* are generated from some other files by texiweb, it
would be good to generate them at build time if texiweb were in
Debian.

The src package is missing a watch file:

http://wiki.debian.org/debian/watch

The src package is missing a get-orig-source rule in debian/rules:

http://www.debian.org/doc/debian-policy/ch-source.html#s-debianrules

Please get the patch and manual pages included upstream.

The patch is missing proper DEP-3 headers (the patch header documents
common ones):

http://dep.debian.net/deps/dep3/

Please remove the comments from debian/rules since they serve no purpose.

The upstream README file doesn't add much that isn't in the manual
page or the package metadata, I would suggest it should not be listed
in debian/docs.

The Vcs-* fields are for the Debian packaging VCS, not the upstream VCS.

I would suggest running wrap-and-sort -sa once now and every time the
debian/control file is changed or other files touched by
wrap-and-sort.

The sentences in the Description: in debian/control are missing
full-stops at the end.

The debhelper build-dep probably doesn't need to be so specific,
debhelper (>= 9) is probably better.

I would suggest build-depending on dh-autoreconf and adding --with
autoreconf to the debian/rules dh line. This will ensure that the
build system is still buildable on Debian. You will also need to
build-depend on autoconf-archive and autoconf-gl-macros for this.

The upstream ChangeLog file is empty, you might want to ask them to
remove it from SVN and use svn2cl to generate it when they are
building tarballs.

toped includes MemTrack, which is meant as a drop-in pair of files. If
this package gets sponsored, please notify the security team about it:

http://wiki.debian.org/EmbeddedCodeCopies

I guess gds2vrml was forked from gds2pov? It would be nice if those
two projects could be re-aligned and merged.

http://www.atchoo.org/gds2pov/

Some files contain an incorrect address for the FSF. You might want to
ask upstream to fix that.

There are lots of fixmes, hacks and todos in the source.

The package fails to build twice in a row (debuild && debuild), which
potentially makes it annoying for the security team and NMUers to make
uploads:

make[3]: Entering directory
`/tmp/buildd/toped-0.9.8.1-r2211/tll/user_functions/tools/logos/examples'
make[3]: *** No rule to make target `distclean'.  Stop.

Automatically found issues:

gcc:

glf.cpp: In function 'int ReadFont(const char*, glf_font*)':
glf.cpp:206:30: warning: ignoring return value of 'size_t fread(void*,
size_t, size_t, FILE*)', declared with attribute warn_unused_result
[-Wunused-result]
glf.cpp:220:40: warning: ignoring return value of 'size_t fread(void*,
size_t, size_t, FILE*)', declared with attribute warn_unused_result
[-Wunused-result]
glf.cpp:223:40: warning: ignoring return value of 'size_t fread(void*,
size_t, size_t, FILE*)', declared with attribute warn_unused_result
[-Wunused-result]
glf.cpp:227:50: warning: ignoring return value of 'size_t fread(void*,
size_t, size_t, FILE*)', declared with attribute warn_unused_result
[-Wunused-result]
glf.cpp:233:32: warning: ignoring return value of 'size_t fread(void*,
size_t, size_t, FILE*)', declared with attribute warn_unused_result
[-Wunused-result]
glf.cpp:234:33: warning: ignoring return value of 'size_t fread(void*,
size_t, size_t, FILE*)', declared with attribute warn_unused_result
[-Wunused-result]
glf.cpp:235:33: warning: ignoring return value of 'size_t fread(void*,
size_t, size_t, FILE*)', declared with attribute warn_unused_result
[-Wunused-result]
glf.cpp:236:31: warning: ignoring return value of 'size_t fread(void*,
size_t, size_t, FILE*)', declared with attribute warn_unused_result
[-Wunused-result]
glf.cpp:263:37: warning: ignoring return value of 'size_t fread(void*,
size_t, size_t, FILE*)', declared with attribute warn_unused_result
[-Wunused-result]
glf.cpp:264:37: warning: ignoring return value of 'size_t fread(void*,
size_t, size_t, FILE*)', declared with attribute warn_unused_result
[-Wunused-result]
glf.cpp:286:62: warning: ignoring return value of 'size_t fread(void*,
size_t, size_t, FILE*)', declared with attribute warn_unused_result
[-Wunused-result]
glf.cpp:288:60: warning: ignoring return value of 'size_t fread(void*,
size_t, size_t, FILE*)', declared with attribute warn_unused_result
[-Wunused-result]
drawprop.cpp: In constructor 'layprop::TGlfFont::TGlfFont(std::string,
std::string&)':
drawprop.cpp:188:29: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
drawprop.cpp:199:33: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
drawprop.cpp:203:39: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
drawprop.cpp:206:34: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
drawprop.cpp:213:40: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
drawprop.cpp: In constructor 'layprop::TGlfSymbol::TGlfSymbol(FILE*)':
drawprop.cpp:84:33: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
drawprop.cpp:86:33: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
drawprop.cpp:88:33: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
drawprop.cpp:97:30: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
drawprop.cpp:98:30: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
drawprop.cpp:109:41: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
drawprop.cpp:112:41: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
cif_lex.cc:1929:13: warning: 'void yy_fatal_error(const char*)'
defined but not used [-Wunused-function]
cif_lex.cc:1461:17: warning: 'void yyunput(int, char*)' defined but
not used [-Wunused-function]
gds_io.cpp: In member function 'double GDSin::GdsRecord::gds2ieee(byte*) const':
gds_io.cpp:175:32: warning: dereferencing type-punned pointer will
break strict-aliasing rules [-Wstrict-aliasing]
gds_io.cpp:217:27: warning: dereferencing type-punned pointer will
break strict-aliasing rules [-Wstrict-aliasing]
gds_io.cpp: In member function 'byte* GDSin::GdsRecord::ieee2gds(double)':
gds_io.cpp:236:32: warning: dereferencing type-punned pointer will
break strict-aliasing rules [-Wstrict-aliasing]
gds_io.cpp: In member function 'bool GDSin::GdsInFile::getNextRecord()':
gds_io.cpp:464:26: warning: dereferencing type-punned pointer will
break strict-aliasing rules [-Wstrict-aliasing]
gds_io.cpp: In member function 'void
GDSin::GdsStructure::importText(GDSin::GdsInFile*, ImportDB&)':
gds_io.cpp:1188:16: warning: variable 'horiJust' set but not used
[-Wunused-but-set-variable]
gds_io.cpp: In member function 'void
GDSin::GdsStructure::importSref(GDSin::GdsInFile*, ImportDB&)':
gds_io.cpp:1260:19: warning: variable 'absMagn' set but not used
[-Wunused-but-set-variable]
gds_io.cpp:1261:19: warning: variable 'absAngl' set but not used
[-Wunused-but-set-variable]
gds_io.cpp: In member function 'void
GDSin::GdsStructure::importAref(GDSin::GdsInFile*, ImportDB&)':
gds_io.cpp:1322:19: warning: variable 'absMagn' set but not used
[-Wunused-but-set-variable]
gds_io.cpp:1323:19: warning: variable 'absAngl' set but not used
[-Wunused-but-set-variable]
calbr_reader.cpp: In member function 'bool
Calbr::CalbrFile::parseCellNameMode(const string&)':
calbr_reader.cpp:572:12: warning: variable 'a' set but not used
[-Wunused-but-set-variable]
calbr_reader.cpp:572:15: warning: variable 'b' set but not used
[-Wunused-but-set-variable]
calbr_reader.cpp:572:18: warning: variable 'c' set but not used
[-Wunused-but-set-variable]
calbr_reader.cpp:572:21: warning: variable 'd' set but not used
[-Wunused-but-set-variable]
calbr_reader.cpp:572:24: warning: variable 'tx' set but not used
[-Wunused-but-set-variable]
calbr_reader.cpp:572:28: warning: variable 'ty' set but not used
[-Wunused-but-set-variable]
tell_lex.cc:2383:13: warning: 'void yy_fatal_error(const char*)'
defined but not used [-Wunused-function]
tellyzer.cpp: In member function 'void
console::toped_logfile::init(std::string, bool)':
tellyzer.cpp:3005:10: warning: unused variable 'locale' [-Wunused-variable]
browsers.cpp: In member function 'void
browsers::DRCBrowser::addRuleCheck(const wxTreeItemId&,
Calbr::drcRuleCheck*)':
browsers.cpp:2298:9: warning: variable 'sz' set but not used
[-Wunused-but-set-variable]
toped.cpp: In member function 'void
tui::TopedFrame::OnEditLayer(wxCommandEvent&)':
toped.cpp:2074:9: warning: unused variable 'layno' [-Wunused-variable]
gdsparse.cpp: In member function 'void GDSParse::ParseLibName()':
gdsparse.cpp:656:81: warning: format '%d' expects argument of type
'int', but argument 3 has type 'size_t {aka long unsigned int}'
[-Wformat]
gdsparse.cpp: In member function 'void GDSParse::ParseSName()':
gdsparse.cpp:681:79: warning: format '%d' expects argument of type
'int', but argument 3 has type 'size_t {aka long unsigned int}'
[-Wformat]
gdsparse.cpp: In member function 'char* GDSParse::GetAsciiString()':
gdsparse.cpp:1050:35: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp: In member function 'int16_t GDSParse::GetTwoByteSignedInt()':
gdsparse.cpp:1028:28: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp: In member function 'int32_t GDSParse::GetFourByteSignedInt()':
gdsparse.cpp:1013:28: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp: In member function 'double GDSParse::GetEightByteReal()':
gdsparse.cpp:973:28: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp:982:25: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp:983:25: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp:984:25: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp:985:25: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp:986:25: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp:987:25: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp:988:25: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp: In member function 'short int GDSParse::GetBitArray()':
gdsparse.cpp:958:28: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp:959:28: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp: In member function 'bool GDSParse::ParseFile()':
gdsparse.cpp:208:34: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsparse.cpp:209:32: warning: ignoring return value of 'size_t
fread(void*, size_t, size_t, FILE*)', declared with attribute
warn_unused_result [-Wunused-result]
gdsobject_vrml.cpp: In member function 'void
GDSObject_vrml::OutputPathToFile(FILE*, GDSObjects*, char*, float,
float, long int*, ProcessLayer*)':
gdsobject_vrml.cpp:89:8: warning: variable 'BgnExtn' set but not used
[-Wunused-but-set-variable]
gdsobject_vrml.cpp: In member function 'void
GDSObject_vrml::DecomposePOVPolygons(FILE*)':
gdsobject_vrml.cpp:623:17: warning: variable 'faceindex' set but not
used [-Wunused-but-set-variable]

dpkg-shlibdeps:

dpkg-shlibdeps: warning: symbol inflate used by
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0
found in none of the libraries
dpkg-shlibdeps: warning: symbol inflateInit2_ used by
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0
found in none of the libraries
dpkg-shlibdeps: warning: symbol inflateEnd used by
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0
found in none of the libraries
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_DB.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_common.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_bidfunc.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libgdsto3d.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_parser.so.0.0.0 were
not linked against libwx_gtk2u_richtext-2.8.so.0 (they use none of the
library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_DB.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_common.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_bidfunc.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libgdsto3d.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_parser.so.0.0.0 were
not linked against libwx_gtk2u_html-2.8.so.0 (they use none of the
library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_DB.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_common.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_bidfunc.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libgdsto3d.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_parser.so.0.0.0 were
not linked against libwx_baseu_xml-2.8.so.0 (they use none of the
library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_DB.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_common.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_bidfunc.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libgdsto3d.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_parser.so.0.0.0 were
not linked against libwx_gtk2u_gl-2.8.so.0 (they use none of the
library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_DB.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_common.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_bidfunc.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libgdsto3d.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_parser.so.0.0.0 were
not linked against libwx_gtk2u_aui-2.8.so.0 (they use none of the
library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_DB.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_common.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_bidfunc.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libgdsto3d.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_parser.so.0.0.0 were
not linked against libwx_gtk2u_xrc-2.8.so.0 (they use none of the
library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_DB.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_common.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_bidfunc.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libgdsto3d.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_parser.so.0.0.0 were
not linked against libwx_gtk2u_qa-2.8.so.0 (they use none of the
library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_DB.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_common.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_bidfunc.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libgdsto3d.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_parser.so.0.0.0 were
not linked against libwx_gtk2u_adv-2.8.so.0 (they use none of the
library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_DB.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_common.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_bidfunc.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libgdsto3d.so.0.0.0
debian/toped-libs/usr/lib/x86_64-linux-gnu/libtpd_parser.so.0.0.0 were
not linked against libwx_baseu_net-2.8.so.0 (they use none of the
library's symbols)

dpkg-gencontrol:

dpkg-gencontrol: warning: Depends field of package toped-tll-libs:
unknown substitution variable ${shlibs:Depends}

lintian:

I: toped source: debian-watch-file-is-missing
W: toped-libs: package-name-doesnt-match-sonames libgdsto3d0
libtpd-DB0 libtpd-bidfunc0 libtpd-common0 libtpd-ifaces0
libtpd-parser0
I: toped-libs: spelling-error-in-binary
usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0 extention extension
W: toped-libs: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/libtpd_parser.so.0.0.0
P: toped-libs: no-upstream-changelog
I: toped-libs: no-symbols-control-file
usr/lib/x86_64-linux-gnu/libtpd_DB.so.0.0.0
I: toped-libs: no-symbols-control-file
usr/lib/x86_64-linux-gnu/libtpd_bidfunc.so.0.0.0
I: toped-libs: no-symbols-control-file
usr/lib/x86_64-linux-gnu/libtpd_parser.so.0.0.0
I: toped-libs: no-symbols-control-file
usr/lib/x86_64-linux-gnu/libtpd_ifaces.so.0.0.0
I: toped-libs: no-symbols-control-file
usr/lib/x86_64-linux-gnu/libtpd_common.so.0.0.0
I: toped-libs: no-symbols-control-file
usr/lib/x86_64-linux-gnu/libgdsto3d.so.0.0.0
P: toped-tll-libs: no-upstream-changelog
W: toped-tll-libs: executable-not-elf-or-script
usr/share/toped/tll/user_functions/tools/logos/config.m
W: toped-tll-libs: executable-not-elf-or-script
usr/share/toped/tll/user_functions/tools/logos/write_tell_script_helper.m
P: toped-utils: no-upstream-changelog
W: toped-utils: unusual-interpreter
usr/share/toped/utils/cadence/virtuoso2tll.ss #!mzscheme

cppcheck:

[tpd_DB/tedstd.h:352]: (error) Used file that is not opened.
[src/toped.cpp:1385]: (error) Uninitialized variable: success
[src/tui.cpp:1401]: (error) Memory leak: newpat
[tpd_DB/tedat.cpp:1601] -> [tpd_DB/tedat.cpp:1602]: (error) Possible
null pointer dereference: seg0 - otherwise it is redundant to check it
against null.
[tpd_DB/tedstd.cpp:582]: (error) Used file that is not opened.
[tpd_DB/tedstd.cpp:586]: (error) Used file that is not opened.
[tpd_DB/tedstd.cpp:590]: (error) Used file that is not opened.
[tpd_DB/tedstd.cpp:594]: (error) Used file that is not opened.
[tpd_DB/tedstd.cpp:647]: (error) Used file that is not opened.
[tpd_DB/tedesign.cpp:1811]: (error) Uninitialized variable: shapes
[utils/gds2vrml_v0.3/libgdsto3d/config_cfg.cpp:513] ->
[utils/gds2vrml_v0.3/libgdsto3d/config_cfg.cpp:515]: (error) Possible
null pointer dereference: pos1 - otherwise it is redundant to check it
against null.
[utils/gds2vrml_v0.3/libgdsto3d/config_cfg.cpp:514] ->
[utils/gds2vrml_v0.3/libgdsto3d/config_cfg.cpp:515]: (error) Possible
null pointer dereference: pos1 - otherwise it is redundant to check it
against null.
[utils/gds2vrml_v0.3/libgdsto3d/config_cfg.cpp:131]: (error) Resource leak: cptr
[utils/gds2vrml_v0.3/libgdsto3d/process_cfg.cpp:63] ->
[utils/gds2vrml_v0.3/libgdsto3d/process_cfg.cpp:68]: (error) Possible
null pointer dereference: layer1 - otherwise it is redundant to check
it against null.
[utils/gds2vrml_v0.3/libgdsto3d/process_cfg.cpp:64] ->
[utils/gds2vrml_v0.3/libgdsto3d/process_cfg.cpp:68]: (error) Possible
null pointer dereference: layer1 - otherwise it is redundant to check
it against null.
[utils/gds2vrml_v0.3/libgdsto3d/process_cfg.cpp:65] ->
[utils/gds2vrml_v0.3/libgdsto3d/process_cfg.cpp:68]: (error) Possible
null pointer dereference: layer1 - otherwise it is redundant to check
it against null.

isutf8:

./utils/gds2vrml_v0.3/src/gdsobject_vrml.cpp: line 309, char 1, byte
offset 82: invalid UTF-8 code

duplicate files:

./src/tpdph.h
./tpd_parser/tpdph.h
./tpd_common/tpdph.h

./tpd_bidfunc/tpdph.cpp
./src/tpdph.cpp
./tpd_parser/tpdph.cpp
./tpd_ifaces/tpdph.cpp
./tpd_DB/tpdph.cpp
./tpd_common/tpdph.cpp

./tpd_bidfunc/tpdph.h
./tpd_ifaces/tpdph.h

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


Reply to: