Bug#684434: RFS: yamcha/0.33-1 [ITP] -- General purpose chunker annotator
Hi Jakub,
finally I found some time to check the issues you reported and some others.
I decided to push my git repository to collab-maint. You can find it here:
Vcs-Git: git://git.debian.org/git/collab-maint/yamcha.git
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/yamcha.git
Il 15/11/2012 17:21, Jakub Wilk ha scritto:
> I tried to run the tests. Even though the final result appears to be "All 4 tests passed", I saw things like this:
>
> *** glibc detected *** ../libexec/pkemine: free(): invalid pointer: 0x40118240 ***
Fixed.
> Typo in debian/patches/2002_autoconf_fixes.patch: CFlAGS -> CFLAGS.
Fixed. This error is also present in tinysvm, I fixed it there too.
I also decided to push my tinysvm's git repository to collab-maint:
Vcs-Git: git://git.debian.org/git/collab-maint/tinysvm.git
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/tinysvm.git
Il 21/11/2012 23:33, Jakub Wilk ha scritto:
> * Giulio Paci <giuliopaci@gmail.com>, 2012-08-10, 00:44:
>> http://mentors.debian.net/debian/pool/main/y/yamcha/yamcha_0.33-1.dsc
>
> I had another look at the package:
>
> Please don't install *.la files (unless you have a good reason to do so).
Fixed.
> Could you expand tabs in debian/control?
Done.
> Typo in developer_files.patch: purpos -> purpose.
Fixed.
> "spro", what's that?
Just a cut-and-paste error.
> I think libyamcha-dev would be a better place for the *.cpp examples.
You are right: moved those samples there.
> Also, the instructions how to build/run them should be updated.
Done.
Thank you very much for your reviews.
Bests,
Giulio.
Reply to: