Re: RFS: MiceAmaze video game
- To: firstname.lastname@example.org
- Subject: Re: RFS: MiceAmaze video game
- From: Raphael Champeimont <email@example.com>
- Date: Fri, 23 Nov 2012 10:36:40 +0100
- Message-id: <CA+_0haKPXFcbaTa76pWt_s+oZBSNEex2MPeL44HiBxGh=rfSRQ@mail.gmail.com>
- In-reply-to: <CAKTje6Fa5bfq_UT1_z1gN4FGKByRK7eWGnQW6_mXN2qvA6eNtA@mail.gmail.com>
- References: <CA+_0haLxSZUmrSgS=9qE4zB62Tb=p2z9pG1s58BXR8sHNfirstname.lastname@example.org> <CAKTje6Fa5bfq_UT1_z1gN4FGKByRK7eWGnQW6_mXN2qvA6eNtA@mail.gmail.com>
Thank you for all your comments.
I will come back later with a new upstream release, especially for the
font rendering which requires big changes. That was probably something
to be done anyway, since I guess it would improve the font rendering
quality which I was not too happy about.
For the rest I will make the necessary changes.
2012/11/23 Paul Wise <email@example.com>:
> You might be interested in joining the Debian games team:
> Here is a review of your package:
> You are missing a watch file:
> You don't include any FreeDesktop menu or Debian menu files, so
> non-technical users will probably not be able to start your game on
> I would suggest to update debian/compat to 9 and change the debhelper
> build-dep to 9
> Your Makefile does not support DESTDIR.
> Your Makefile includes this very inappropriate line:
> I would suggest dropping the whole release/debug thing, this will
> allow you to use the more standard CXXFLAGS instead of
> CXXFLAGS_RELEASE/CXXFLAGS_DEBUG/CXXFLAGS_COMMON. Alternatively you
> could just switch to a standard build system like autotools or cmake.
> I would strongly suggest that the text be rendered at runtime or at
> the very least the PNG files created from the DejaVu font should
> rendered at build time from ttf-dejavu. Rendering the text at runtime
> will allow you to add translations, making the game accessible to more
> users. I would recommend quesoglc for this. I would recommend these
> files be rendered at runtime or build time:
> I would suggest that these files be created from mouse.png at build
> time using imagemagick or similar: icon.ico icon32.bmp
> The eagle.png image looks like it was cut out of some off-the-shelf
> clipart. Are you the copyright holder for that? Where did the image
> come from? Is there an SVG/WMF that it was rendered from (best render
> at build time)?
> You are embedding a copy of SOIL. Please remove that from the upstream
> tarball and build-depend on libsoil-dev instead. That would also get
> rid of one gcc warning, one lintian warning and two cppcheck warnings.
> Your debian/changelog includes UNRELEASED in the suite, shouldn't that
> be "unstable"?
> All of the files in src/ have "All rights reserved." in them but no
> license statement:
> Your configuration file loading should use getpwuid() or similar if
> getenv('HOME') fails.
> src/Functions.* are not valid UTF-8.
> You might want to use the new format for debian/copyright:
> Since you are upstream for a game, please read these documents:
> Automatic checks from here:
> gcc -O2 -s -Wall -o obj/stb_image_aug.o -c ../../src/stb_image_aug.c
> ../../src/stb_image_aug.c: In function 'parse_png_file':
> ../../src/stb_image_aug.c:2341:28: warning: variable 'invalid_chunk'
> set but not used [-Wunused-but-set-variable]
> P: miceamaze source: source-contains-prebuilt-windows-binary SOIL/testSOIL.exe
> I: miceamaze source: debian-watch-file-is-missing
> P: miceamaze: no-upstream-changelog
> [SOIL/src/original/stb_image-1.16.c:2924]: (error) Memory leak: out
> [SOIL/src/stb_image_aug.c:2651]: (error) Memory leak: out
> src/Functions.h: line 63, char 1, byte offset 11: invalid UTF-8 code
> src/Functions.cpp: line 84, char 1, byte offset 20: invalid UTF-8 code