[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: mp3diags at mentors

On Fri, Oct 12, 2012 at 1:38 PM, Bart Martens <bartm@debian.org> wrote:
Hi Josue,

I had a look at mp3diags at mentors uploaded there on 2012-10-12 06:43.  I'm
afraid that bug 689811 is not yet fully solved.

For example, upstream wrote that "the icons are mainly taken from KDE 4' Oxygen
icon set", and I don't see the copyright holder(s) mentioned in

Also, the text from upstream you quoted is helpful for clarification, as part
of the fix for bug 689811.  I suggest to add the exact text in debian/copyright
including the From and Date headers.

And since you're updating the package anyway : the white lines in debian/rules
are still there.  You may want to remove them before requesting an unblock to
debian-release with a debdiff.


Bart Martens

Hi Bart,
Thanks for the review , I'll try to fix it today 
Josue Ortega 
PGP key 4096R/AB4AFD3F 2012-08-20
Fingerprintt = 7733 B328 D279 5F5B E232  5ADD 0150 9D5C AB4A FD3F

Reply to: