tags 686679 + moreinfo thanks Hi Eugene, On 04.09.2012 18:23, Eugene Seliverstov wrote: > A package asn1c was previously maintained by W. Martin Borgert <debacle@debian.org> > but it was removed from testing and unstable distributions due to lack of adopters. > Current package is based on original package and includes several new patches > to conform with latest Debian Policy. this is a review of your package. * Do not install Lintian overrides for manpage-has-errors-from-man. The warning is legit, but of minor importance. Either fix it, or ignore it. * You are missing several uploads of asn1c which were in Debian at some point after Squeeze's version. You can find the latest package in [1]. Consequently your version number is too low. 0.9.21.dfsg-1 was in Debian already in 2007 (uploaded 21 Jun 2007). Please use at very least 0.9.21.dfsg-5. Moreover, please import the delta of changes since then to your package. * There is a SVN repository for the packaging [2]. Please update that and add it to your control file [3] * In debian/rules, please remove the boilerplate blind text. * At your choice, either document how to build a repacked tarball (you need to remove the IETF files from the tarball as you probably know) in debian/README.source [4] or make a get-orig-source [5] target (or both). * I couldn't find the source for the PDF files you install from doc/ (the preferred form for modification that is). Please include it in your source package, or remove it while repacking the tarball. * Please add a DEP-3 header to your patches [6]. Also consider sending it upstream, unless you did already. * debian/copyright wrongly claims, the package would be subject to the BSD-2-clause license. Actually it is 3-clause. [1] http://snapshot.debian.org/package/asn1c/0.9.21.dfsg-4/ [2] http://anonscm.debian.org/viewvc/collab-maint/deb-maint/asn1c/ [3] http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-vcs [4] http://www.debian.org/doc/debian-policy/ch-source.html#s-readmesource [5] http://www.debian.org/doc/debian-policy/ch-source.html#s-debianrules [6] http://dep.debian.net/deps/dep3/ -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D
Attachment:
signature.asc
Description: OpenPGP digital signature