[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#683184: RFS: suckless-tools/39-1 [ITA]



On 20:32 Fri 24 Aug     , Jakub Wilk wrote:
> You create the empty suckless-tools_${version}.orig.tar.gz tarball
> in the wrong directory.

Ok I messed up. It was fine till I didn't introduced the mktemp to
create secure tmp directory. But when I did I forgot to check where on
earth the .orig.tar.gz was created. I will fix this

> Why do you redirect tar's stderr to /dev/null?

Just to keep the output clean. Is that not recommended? If so I will
remove it

> I recommend passing these options to tar, so that the user's
> name/group/umask are not leaked:
> 
> --owner root --group root --mode a+rX

Ok I will fix it

> Have you seen #685611?

Just now noticed it. It went to original maintainer who orphaned
thanks for pointing out. I will reply for the bug on the bug itself.

Will prepare a new source and ping you again

Regards
-- 
Vasudev Kamath
http://copyninja.info
Connect on ~friendica: copyninja@{frndk.de | vasudev.homelinux.net}
IRC nick: copyninja | vasudev {irc.oftc.net | irc.freenode.net}
GPG Key: C517 C25D E408 759D 98A4  C96B 6C8F 74AE 8770 0B7E

Attachment: signature.asc
Description: Digital signature


Reply to: