Bug#684106: New LedgerSMB Debian package, v1.3.21-1
Hi,
On Mon, 06 Aug 2012, Robert James Clay wrote:
> Besides uploading the new package version to the Mentors site, I went
> ahead & submitted a Request for Sponsor bug as well (#684106 [1])
Here's my review of your package:
In control:
Recommends: default-mta | mail-transport-agent, texlive-latex-recommended, libopenoffice-oodo
c-perl,
- libmath-bigint-gmp-perl, libparse-recdescent-perl, libtemplate-plugin-latex-perl
-Suggests: postgresql, lpr, libnet-tclink-perl, latex-cjk-all,
- libimage-size-perl
+ libmath-bigint-gmp-perl, libparse-recdescent-perl
+Suggests: postgresql, lpr, libnet-tclink-perl, latex-cjk-all
This change is not documented in debian/changelog. Why did you remove
those recommendations/suggestions ?
In preinst:
+# Set old_version variable for use later in the script.
+old_version=$2
You do not seem to use $old_version later. Drop it.
+ if dpkg --compare-versions $2 lt 1.3.19-1; then
+ # If symbolic links for css and templates directories to the
+ # /var/lib/ledgersmb exist, then remove them.
+ if [ -h "/usr/share/ledgersmb/css" ]; then
+ rm -f /usr/share/ledgersmb/css
+ fi
+ if [ -h "/usr/share/ledgersmb/templates" ]; then
+ rm -f /usr/share/ledgersmb/templates
+ fi
+ fi
1.3.19-1 doesn't appear in the changelog and has never been released
to Debian. You should better use 1.3.21-1 as version for this check.
Also please don't use 2-spaces indent, they are unreadable. Use at least 4
spaces. And be consistent.
I think you have duplicated some information in debian/NEWS too (the para
starting with "Empty language specific" in 1.3.21-1 is almost the same as
the one in 1.3.18-1).
Please fix all those issues and I will upload the updated package.
Now concerning the inclusion of this updated package in wheezy, my
experience of Debian led me to believe that you will have a hard time
convincing release managers to let this update in. The fact that
security updates are mixed in new upstream releases mean that there's no
"stable branch" that can be safely maintained over the course of 3 years.
They could possibly suggest you to remove the package instead since it
can't be supported in stable.
Thus you should maybe ask upstream how long they intend to support the
1.3 branch and whether they are willing to provide targetted security
fixes for the version released in Debian in the case of future security
issues?
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Get the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/
Reply to: