On Tue, Jul 31, 2012 at 2:47 AM, Mathieu Malaterre
<malat@debian.org> wrote:
Gary,
Mathieu,
I've uploaded a new version of the package to mentors with most of your suggestions. I'm going to work on pulling in the most recent release now as we figure the few things left out.
Thanks for packaging ninja. Here are a few comments:
No problem, I want to use it more so it only makes sense ;)
- Please use format 1.0 [1] for copyright. Do not forget to list your
own copyright (debian/* files).
Done.
- You are missing proper version check in d/control. On my stable system I get:
g++-4.4.real: no input files
[10/24] CXX build/build_test.o
ninja: build stopped: subcommand failed.
make[1]: *** [override_dh_auto_build] Error 1
-> looks like you need a min version for gtest-dev
I set the minimum for gtest-dev to 1.6.0, I'm not sure exactly what it is as it's not called out upstream, but I can play with it a bit and see what I can do.
- I believe you can simplify d/rules. Since you use d/compat=9, you do
not need to specify the explicit hardening settings in d/rules.
I removed the hardening stuff but got the following warning from lintian.
W: ninja-build: hardening-no-fortify-functions usr/bin/ninja
- On a side chroot, the build fails with:
PYTHON="python"' -O2 -DNDEBUG -g -O2 -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Werror=format-security -fPIE
-fstack-protector --param ssp-buffer-size=4 -D_FORTIFY_SOURCE=2
-Wformat -Wformat-security -Werror=format-security -c
src/build_log_perftest.cc -o build/build_log_perftest.o
src/build_log_perftest.cc: In function 'int main()':
src/build_log_perftest.cc:135:23: error: 'unlink' was not declared in this scope
[21/24] CXX build/util_test.o
ninja: build stopped: subcommand failed.
What debian version is the chroot?
- Thanks.
[1] http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/