Re: Bug#683336: RFS: ninja-build/120508+git638b033
Gary,
Thanks for packaging ninja. Here are a few comments:
- Please use format 1.0 [1] for copyright. Do not forget to list your
own copyright (debian/* files).
- You are missing proper version check in d/control. On my stable system I get:
g++-4.4.real: no input files
[10/24] CXX build/build_test.o
ninja: build stopped: subcommand failed.
make[1]: *** [override_dh_auto_build] Error 1
-> looks like you need a min version for gtest-dev
- I believe you can simplify d/rules. Since you use d/compat=9, you do
not need to specify the explicit hardening settings in d/rules.
- On a side chroot, the build fails with:
PYTHON="python"' -O2 -DNDEBUG -g -O2 -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Werror=format-security -fPIE
-fstack-protector --param ssp-buffer-size=4 -D_FORTIFY_SOURCE=2
-Wformat -Wformat-security -Werror=format-security -c
src/build_log_perftest.cc -o build/build_log_perftest.o
src/build_log_perftest.cc: In function 'int main()':
src/build_log_perftest.cc:135:23: error: 'unlink' was not declared in this scope
[21/24] CXX build/util_test.o
ninja: build stopped: subcommand failed.
- Thanks.
[1] http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Reply to: