Bug#682035: RFS: maxwell/1.2-1 (ITP #662736)

[Benoît Knecht <benoit.knecht@fsfe.org>]

Benoît Knecht wrote:
> There are a few lintian warnings that you should fix:
> 
>   P: maxwell source: unversioned-copyright-format-uri http://dep.debian.net/deps/dep5
>   W: maxwell: hardening-no-relro usr/bin/maxwell
>   W: maxwell: hardening-no-fortify-functions usr/bin/maxwell
>   P: maxwell: no-upstream-changelog
>   W: maxwell: new-package-should-close-itp-bug
> 
> According to debian/copyright, the entire source is GPL-2, but only
> maxwell.c has a header mentioning GPL-2 (and not even the standard GPL
> header); there's no copy of the GPL included in the package either. You
> should ask upstream to add license headers to every source file
> (including the man page), following the instructions in the last section
> of the GPL [1], and a full copy of the GPL in a LICENSE file.
> 
> [1] https://www.gnu.org/licenses/gpl-2.0.html
> 
> Also, the source of Maxwell.pdf is missing.
> 
> Other than that, the watch file isn't working:
> 
>   uscan warning: Filename pattern missing version delimiters ()
>     in debian/watch, skipping:
>     ftp://ftp.cs.sjtu.edu.cn:990/sandy/maxwell\.tgz

I forgot to mention one thing. Line 8 of maxwell.8 sets the line length
to +8, which leads to a very strange layout. Please remove that line.

Cheers,

-- 
Benoît Knecht