Bug#666243: RFS: peg/0.1.9-1 [ITP] -- recursive-descent parser generators for C

[Jakub Wilk <jwilk@debian.org>]

The current version appears to be at:
http://mentors.debian.net/debian/pool/main/p/peg/peg_0.1.9-1.dsc

Lintian says:
P: peg source: package-lacks-versioned-build-depends-on-debhelper 7
W: peg: hardening-no-relro usr/bin/leg
W: peg: hardening-no-relro usr/bin/peg

blhc confirms that there's a problem with LDFLAGS:
LDFLAGS missing (-Wl,-z,relro): cc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -o peg-new peg.o tree.o compile.o
LDFLAGS missing (-Wl,-z,relro): cc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -o leg-new leg.o tree.o compile.o

The examples directory could act as a test suite. Please run it at build 
time.

In my opinion, the long description is a bit too… long. I would remove 
at least the citation, maybe something more, but I'm not sure what. You 
might want to ask debian-l10n-english@ for an advice.

Please merge changelog entries for 0.1.7-1, 0.1.8-1 and 0.1.9-1 into 
one.

It would be probably better not to compress examples. Compression makes 
playing with them a bit harder, whereas the space savings are minute.

Upstream makefile strips the binaries unconditionally. However, for 
Debian, binaries should be not stripped if the package was built with 
DEB_BUILD_OPTIONS=nostrip.

Please forward manpage_fixes.patch upstream.

I always feel uneasy about “Forwarded: not-needed” patches. I believe 
parts of makefile_configuration.patch could be forwarded upstream, and 
the rest of the logic could be moved to debian/rules:

> all : peg leg
> +   cp -a peg.1 leg.1

Wouldn't it be better to make leg manpage a symlink to peg one, instead 
of shipping two identical files? You could ask upstream to include the 
symlink directly in their tarball.

> -ROOT   =
> +ROOT   = $(DESTDIR)

This could be forwarded upstream.

> -PREFIX = /usr/local
> +PREFIX = /usr

Could be overridden in debian/rules.

> $(BINDIR)/% : %
> +   mkdir -p $(BINDIR)
>    cp -p $< $@
>    strip $@

Could be forwarded upstream.

> %.peg-c : %.peg compile.c
> -   ./peg -o $@ $<
> +   #./peg -o $@ $<
>
> leg.o : leg.c
>
> leg.c : leg.leg compile.c
> -   ./leg -o $@ $<
> +   #./leg -o $@ $<

Hmm, why?

--
Jakub Wilk