Your message dated Sat, 30 Jun 2012 14:19:45 +0000 with message-id <20120630141945.GA10770@master.debian.org> and subject line closing RFS: iptables-persistent/0.5.3+nmu2 [NMU] has caused the Debian Bug report #676927, regarding RFS: iptables-persistent/0.5.3+nmu2 [NMU] to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 676927: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=676927 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: RFS: iptables-persistent/0.5.3+nmu2 [NMU]
- From: Andreas Rütten <AndreasRuetten@gmx.de>
- Date: Sun, 10 Jun 2012 17:45:42 +0200
- Message-id: <[🔎] 20120610174542.6336305f@zypern>
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "iptables-persistent" * Package name : iptables-persistent Version : 0.5.3+nmu2 Upstream Author : Simon Richter <sjr@debian.org>, Chris Silva <racerx@makeworld.com>, Jonathan Wiltshire <jmw@debian.org> * License : GPL-3 Section : admin It builds those binary packages: iptables-persistent - boot-time loader for iptables rules To access further information about this package, please visit the following URL: http://mentors.debian.net/package/iptables-persistent Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/i/iptables-persistent/iptables-persistent_0.5.3+nmu2.dsc Changes since the last upload: iptables-persistent (0.5.3+nmu2) unstable; urgency=low * Non-maintainer upload. * Fix postinst fails with legacy boot ordering due to wrong call to update-rc.d (Closes: #651838) * Fix insserv issue if upgrading from <=0.5.2 (Closes: #665814) * Replace the utilisation of dpkg-maintscript-helper by a simple mv (Closes: #665813) -- Andreas Rütten <AndreasRuetten@gmx.de> Sun, 10 Jun 2012 02:42:53 +0200 Please find attached patches for all changes between this version and version 0.5.3+nmu1. Before I prepared this NMU I tried several times to get in touch with the maintainer (Jonathan Wiltshire) and offered some help and patches. Unfortunately with not much success. I do know that he isn't really MIA. There are at least four mails from him on d-devel in May. But the last time I get any response from him was in February where he promised to get in touch with me. Now as it's June and the freeze is coming closing I'm looking for a sponsor which could help me to get at least some bugs fixed. Regards, Andreas Rütten PS: I also prepared patches for all Lintian warnings which will be reported against this version. They aren't include them in this NMU because they are only cosmetic or informational ones. If desired I could easily include them. -- Andreas Rütten AndreasRuetten@gmx.de 4096R: 0x6C9DFFB2 / 8394 99DA 59BD BCE2 3FC8 3A9E 6633 0089 6C9D FFB2From 8366126261de509485a3fe7d0eb5355dd8cd0766 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20R=C3=BCtten?= <AndreasRuetten@gmx.de> Date: Mon, 12 Dec 2011 16:08:01 +0100 Subject: [PATCH 1/4] Fix postinst fails with legacy boot ordering due to wrong call to update-rc.d Closes: #651838 --- debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index 62a4b67..1cf2ee8 100755 --- a/debian/rules +++ b/debian/rules @@ -1,7 +1,7 @@ #!/usr/bin/make -f override_dh_installinit: - dh_installinit -- start 37 2 3 4 5 . stop 37 0 1 6 + dh_installinit -- start 37 2 3 4 5 . stop 37 0 1 6 . %: dh $@ -- 1.7.9.5From 48bbca980bc4fb8cbcec87bfc68b4df1a72640fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20R=C3=BCtten?= <AndreasRuetten@gmx.de> Date: Sat, 21 Apr 2012 00:36:25 +0200 Subject: [PATCH 2/4] Fix insserv issue if upgrading from <=0.5.2 Between version 0.5.2 and 0.5.3 was a change to the runlevel configuration (#65001). This leads to a problem for insserv during an upgrade from a version <= 0.5.2 to version 0.5.3 and above. To fix this remove the old runlevel configuration during preinst so that the upgrade could create the new intended one during postinst. Closes: #665814 --- debian/iptables-persistent.preinst | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/debian/iptables-persistent.preinst b/debian/iptables-persistent.preinst index 6c554cf..e28cc4a 100644 --- a/debian/iptables-persistent.preinst +++ b/debian/iptables-persistent.preinst @@ -7,4 +7,20 @@ if dpkg-maintscript-helper supports mv_conffile 2>/dev/null; then /etc/iptables/rules /etc/iptables/rules.v4 0.0.20101230 -- "$@" fi +case "$1" in + install|upgrade) + if dpkg --compare-versions "$2" le "0.5.2"; then + update-rc.d -f iptables-persistent remove + fi + ;; + + abort-upgrade) + ;; + + *) + echo "preinst called with unknown argument \`$1'" >&2 + exit 1 + ;; +esac + #DEBHELPER# -- 1.7.9.5From df79662192ca163bec040fa0f9ca1e8583c56677 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20R=C3=BCtten?= <AndreasRuetten@gmx.de> Date: Fri, 20 Apr 2012 17:17:17 +0200 Subject: [PATCH 3/4] Replace the utilisation of dpkg-maintscript-helper by a simple mv MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit dpkg-maintscript-helper is written to deal with conffiles and not with configuration files Neither the old rules file nor the new rules.v4 file are conffiles so dpkg-maintscript-helper wouldn't handle the renaming properly Thanks to Neil Wilson and Raphaël Hertzog for the discussion on Launchpad Bugs #967018 #985508 to figure this out Closes: #665813 --- debian/iptables-persistent.postinst | 5 ----- debian/iptables-persistent.postrm | 5 ----- debian/iptables-persistent.preinst | 9 ++++++--- 3 files changed, 6 insertions(+), 13 deletions(-) diff --git a/debian/iptables-persistent.postinst b/debian/iptables-persistent.postinst index 214c81c..733ecd8 100644 --- a/debian/iptables-persistent.postinst +++ b/debian/iptables-persistent.postinst @@ -5,11 +5,6 @@ set -e # Source debconf library . /usr/share/debconf/confmodule -if dpkg-maintscript-helper supports mv_conffile 2>/dev/null; then - dpkg-maintscript-helper mv_conffile \ - /etc/iptables/rules /etc/iptables/rules.v4 0.0.20101230 -- "$@" -fi - case "$1" in configure) db_get iptables-persistent/autosave_done || true diff --git a/debian/iptables-persistent.postrm b/debian/iptables-persistent.postrm index 0e184ff..704462a 100644 --- a/debian/iptables-persistent.postrm +++ b/debian/iptables-persistent.postrm @@ -2,11 +2,6 @@ set -e -if dpkg-maintscript-helper supports mv_conffile 2>/dev/null; then - dpkg-maintscript-helper mv_conffile \ - /etc/iptables/rules /etc/iptables/rules.v4 0.0.20101230 -- "$@" -fi - case "$1" in purge) rm -rf /etc/iptables/rules \ diff --git a/debian/iptables-persistent.preinst b/debian/iptables-persistent.preinst index e28cc4a..6c7f557 100644 --- a/debian/iptables-persistent.preinst +++ b/debian/iptables-persistent.preinst @@ -2,9 +2,12 @@ set -e -if dpkg-maintscript-helper supports mv_conffile 2>/dev/null; then - dpkg-maintscript-helper mv_conffile \ - /etc/iptables/rules /etc/iptables/rules.v4 0.0.20101230 -- "$@" +if [ -e /etc/iptables/rules ]; then + if [ -e /etc/iptables/rules.v4 ]; then + mv -f /etc/iptables/rules /etc/iptables/rules.v4.dpkg-old + else + mv -f /etc/iptables/rules /etc/iptables/rules.v4 + fi fi case "$1" in -- 1.7.9.5From 49bf5cf37508be100582c3e24e4a709006acac6d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20R=C3=BCtten?= <AndreasRuetten@gmx.de> Date: Sun, 10 Jun 2012 02:43:17 +0200 Subject: [PATCH 4/4] Changelog entries for 0.5.3+nmu2 --- debian/changelog | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/debian/changelog b/debian/changelog index edfae69..beeb07f 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,14 @@ +iptables-persistent (0.5.3+nmu2) unstable; urgency=low + + * Non-maintainer upload. + * Fix postinst fails with legacy boot ordering due to wrong call to + update-rc.d (Closes: #651838) + * Fix insserv issue if upgrading from <=0.5.2 (Closes: #665814) + * Replace the utilisation of dpkg-maintscript-helper by a simple mv + (Closes: #665813) + + -- Andreas Rütten <AndreasRuetten@gmx.de> Sun, 10 Jun 2012 02:42:53 +0200 + iptables-persistent (0.5.3+nmu1) unstable; urgency=low * Non-maintainer upload. -- 1.7.9.5Attachment: signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
- To: 676927-done@bugs.debian.org
- Subject: closing RFS: iptables-persistent/0.5.3+nmu2 [NMU]
- From: Bart Martens <bartm@debian.org>
- Date: Sat, 30 Jun 2012 14:19:45 +0000
- Message-id: <20120630141945.GA10770@master.debian.org>
No package at mentors, and 0.5.4 in unstable. http://packages.qa.debian.org/i/iptables-persistent/news/20120630T113640Z.html
--- End Message ---