Bug#677935: RFS: cwm/5.1-1 [ITP] -- Lightweight and efficient window manager for X11
James McDonald wrote:
> On Mon, Jun 25, 2012 at 05:05:50PM +0200, Benoît Knecht wrote:
> > I took a look at your package, here are a few comments:
>
> Thanks for your detailed review! Your remarks are very helpful.
You're welcome! I'm glad I could help.
> [...]
>
> > Your long description repeats information provided by the short
> > description; see [1] for best practices. It could also be expanded a
> > bit.
>
> I had in fact just repeated the summary from the manpage. I have read the
> reference and a few examples and tried to make it more useful. What do you
> think?
Much better in my opinion. I would remove the last sentence of the first
paragraph though (about the code that used to come from 9wm), as it
doesn't seem very relevant anymore.
The package looks pretty good to me now, so I hope you'll find a sponsor
soon. But prehaps you should consider Depending on xserver-xorg (or at
least Recommend it, if that makes more sense). You could also Suggest
xinit, as it seems like a nice way to start such a minimalistic window
manager.
And here are a couple more nitpickings, if you feel like fixing those:
- In debian/control, the debhelper version dependency should simply be
">= 9" instead of ">= 9.0.0".
- And in the same file, the long description contains a few
double-spaces.
Cheers,
--
Benoît Knecht
Reply to: