[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#678500: RFS: cppreference-doc/20120620-1 [ITP] -- C and C++ standard library reference manual for English language.



Hi Simon,

Many thanks for your input.

On 06/22/2012 05:29 PM, Simon Chopin wrote:
I can't download the most recent tarball from [5], the server gives me
back a 404 error.  I haven't tried the other tarballs though.

Fixed.

In debian/control, wget and httracks are in Build-Depends. It seems to
be a mistake since the build process doesn't download anything. In any
case, the build process should be self-contained and not require network
access.

Fixed.

Why do you need the Replaces/Breaks fields for ? Those packages have
never been in Debian AFAICT.

cppreference-doc-en has been available from my Ubuntu PPA for some time. I thought it'd be good idea to provide an update path for those who will jump straight to Debian version, skipping an update from the PPA, which makes cppreference-doc-en obsolete. On the other hand, the number of such users is probably very small as most of them should've upgraded already, so it makes sense to have cleaner Debian package.

debian/cppreference-doc-en.install and debian/docs are empty, you can
just delete them.

Fixed.

I don't know about the Devref stuff, but you might  want to install the
stuff in /usr/share/doc/* using dh_installdocs. I might very well be
wrong though.

dh_installdocs installs the documentation in /usr/share/doc/<package>. The problem with this is that eventually there will be many cppreference-doc-<lang>-<format> packages, which will share quite a lot of common data. Because of that, it's much easier to assemble the documentation in a single place. dh_installdocs doesn't offer such flexibility AFAICT.

Since the purpose of the package is to provide documentation, it would
be really nice to provide some doc-base informations.

Fixed.

Lintian has some minor nitpicks, some easy to fix. Run
     lintian -EvIiL +pedantic
on your .changes file to see what those are as well as their
explanations.

Fixed. The package is now completely lintian-clean.

I am not sure in what extent this is mandatory for non-D[MD]s, but
people in Debian usually disclose their civilian name. If you intend to
apply for DM or DD status, you would have to disclose it eventually for
the keysigning process.

Well, I don't currently have plans to become DM or DD. Nonetheless, there shouldn't be any problems to associate my contributions to my real name if I change my mind. In any case, there's, AFAIK, no identity check for non-DM/DDs, so both p12 and Name Surname are identical for the purposes of identification. The only difference is that it's obvious that the former is a pseudonym :)

By the way, it seems that there _are_ DDs who use pseudonyms. I could find at least three here http://www.debian.org/devel/people.

About the README.source, I am not exactly sure of how this all works on
the upstream side, but it would be nice to provide a get-orig-source
target to easily build the complete tarball.

It looks like README.source wasn't needed at all. The package is completely self-contained.

Cheers,

Simon


Regards,
p12




Reply to: