[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#677013: RFS: time



Hi Bart,

Bart Martens wrote:
> The file debian/copyright "should name the original authors", and
> David Keppel is such an author.

Thank you for taking the time to look at the copyright file in detail.
I admit the new DEP5 format confuses me.  I need to find some actual
examples in the field of more than the very simple examples listed in
the documentation.  I am working from this document:

  http://dep.debian.net/deps/dep5/

Where would I find such a statement in the documentation?  How would
this be defined in the file?  How would we comply with that statement
within the restrictions of the above documentation?

The copyright holder is of course the FSF.  That is the copyright
statement listed in each of the files.

Should I list the original authors in a Comment: field?  I see no
other way.  Help!

> The previous package maintainers are also copyright holders of debian/* so
> debian/copyright needs an update for that.  Please talk to the previous
> maintainers if there is doubt on the license(s) for debian/*.

I walked through the Debian changelog and compiled a list of
contributors and years from it.

> The years in the main copyright notice are not correct.  For example, time.c
> additionally has "1990, 91, 92".

Good catch.  I definitely missed that.  And not sure where I pulled
that line from.  And getopt.c goes back to 1987.

I walked through every source file and compiled a list of copyright
years from each file.

It seems that I can also collapse the license definition somewhat too.

Working through the above this is the next release candidate version.
How does this look?  Any additional comments concerning this?  Such as
how to "name the original authors"?

================>snip<================
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: time
Source: http://ftp.gnu.org/pub/gnu/time/time-1.7.tar.gz

Files: *
Copyright: Copyright 1987-1996 Free Software Foundation, Inc.
License: GPL-2+

Files: debian/*
Copyright: Copyright 1995 Peter Tobias <tobias@et-inf.fho-emden.de>
           Copyright 1995-2004 Dirk Eddelbuettel <edd@qed.econ.queensu.ca>
           Copyright 2005, 2008 Tollef Fog Heen <tfheen@debian.org>
           Copyright 2010 Salvatore Bonaccorso <salvatore.bonaccorso@gmail.com>
           Copyright 2012 Bob Proulx <bob@proulx.com>
License: GPL-2+

Files: debian/time.1
Copyright: Copyright 1996 Dirk Eddelbuettel <edd@miles.econ.queensu.ca>
License: freely redistributable
 Copyright Dirk Eddelbuettel but freely redistributable

License: GPL-2+
 This program is free software; you can redistribute it
 and/or modify it under the terms of the GNU General Public
 License as published by the Free Software Foundation; either
 version 2 of the License, or (at your option) any later
 version.
 .
 This program is distributed in the hope that it will be
 useful, but WITHOUT ANY WARRANTY; without even the implied
 warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
 PURPOSE.  See the GNU General Public License for more
 details.
 .
 You should have received a copy of the GNU General Public
 License along with this package; if not, write to the Free
 Software Foundation, Inc., 51 Franklin St, Fifth Floor,
 Boston, MA  02110-1301 USA
 .
 On Debian systems, the full text of the GNU General Public
 License version 2 can be found in the file
 `/usr/share/common-licenses/GPL-2'.
================>snip<================

> The package uses source format "3.0 (quilt)" but does not really use
> quilt, so debian/README.source can be removed.

I was working from the Debian quilt howto here which said it was
required.  Of course that is explicitly for Perl but for this aspect
it shouldn't matter.

  http://pkg-perl.alioth.debian.org/howto/quilt.html#readme_source

I find it annoying so am happy to remove it.  But I find your
statement that the quilt format doesn't use quilt surprising!  And in
fact it was required specifically that I convert the package to use
the quilt format.

Pending review of the above (or any other comment) here is the next
release candidate in full:

  http://www.proulx.com/~bob/debian/pool/sid/main/time/2012-06-22/

  -rw-r--r-- 1  16639 Jun 22 17:35 time_1.7-24.debian.tar.gz
  -rw-rw-r-- 1   1038 Jun 22 17:39 time_1.7-24.dsc
  -rw-r--r-- 1  12317 Jun 22 17:36 time_1.7-24_amd64.build
  -rw-rw-r-- 1   2468 Jun 22 17:39 time_1.7-24_amd64.changes
  -rw-r--r-- 1  32904 Jun 22 17:36 time_1.7-24_amd64.deb
  -rw-rw-r-- 1 103066 Aug  9  1997 time_1.7.orig.tar.gz

However note the above request for help in the item "should name the
original authors".

Bob

Attachment: signature.asc
Description: Digital signature


Reply to: