Hi Bart, On Sa 09 Jun 2012 06:47:27 CEST Bart Martens wrote:
On Fri, Jun 08, 2012 at 11:03:31PM +0200, Mike Gabriel wrote:Hi all (esp. Bart, who already took a look at the formerly uploaded package),On Fr 08 Jun 2012 15:39:53 CEST Mike Gabriel wrote: > * Package name : x2goclient > Version : 3.99.2.1-2 > Upstream Author : Oleksandr Shneyder > * URL : http://wiki.x2go.org > * License : GPL-2+ > Section : x11 >
Quoting your comment on mentors (x2goclient package) here:
The file Makefile.docupload has "Copyright (C) 2010-2012 by Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, GPLv3 applies to this file" but that is not mentioned in debian/copyright. Maybe you want to give that file to the upstream copyright holders, but that is obviously entirely up to you.
I found "Copyright (C) 2005-2012 Obviously Nice - http://www.obviouslynice.de"; in LICENSE, and the mentioned years 2005-2012 don't match 2007 in debian/copyright.
Both issues fixed: http://anonscm.debian.org/gitweb/?p=collab-maint/x2go/x2goclient.git;a=commitdiff;h=9ab196be89ac04d536577df2c9fd9b129519c454
I would not add AUTHORS in debian/x2goplugin.docs because the two authors should be mentioned in debian/copyright.http://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile "should name the original authors"
Fixed: http://anonscm.debian.org/gitweb/?p=collab-maint/x2go/x2goclient.git;a=commitdiff;h=54a9c913cbf47644b15218997cacca542881a18f http://anonscm.debian.org/gitweb/?p=collab-maint/x2go/x2goclient.git;a=commitdiff;h=d266176ba0401ae6a10612b4e0bfd86b22912138
You may want to combine 3.99.2.1-2 and 3.99.2.1-1 into just 3.99.2.1-1, but that's optional.
Done: http://anonscm.debian.org/gitweb/?p=collab-maint/x2go/x2goclient.git;a=commitdiff;h=fcbaaf1356994481a9c03b9439b86bb609e19003
When I compare debian/changelog in the upstream tarball with debian/upstream/changelog in your package at mentors, I see quite some differences. Shouldn't these files be identical ? (I guess that these differences confused > me during my previous review.)
The upstream team (I am a member of upstream, as well) uses the ,,Debian'' changelog for upstream changelogging. We (in upstream) use -0 revisions for packages provided to the community and document all code changes in the debian/changelog. For Debian packaging of x2goclient (and other X2Go components) I move this files out of the way, maintain a Debian-specific changelog and place the upstream ,,Debian'' changelog as upstream log into the package.
Thanks for taking your time. May you look again (in 30min or so)? I will now drop the x2goclient upload on mentors and re-upload as 3.99.2.1-1.
Greets, Mike -- DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148 GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
Attachment:
pgp51N8n91x5l.pgp
Description: Digitale PGP-Unterschrift