[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#671745: RFS: logsurfer/1.8-2 [ITP]



Hi Salvatore,

thanks for the review! Finally I had some time to work on the package.
See my comments below.

Am 12.05.2012 um 10:02 schrieb Salvatore Bonaccorso:
On Sun, May 06, 2012 at 05:08:42PM +0200, Thilo Uttendorfer wrote:
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "logsurfer"

 Package name    : logsurfer
 Version         : 1.8-2
 Upstream Author : Kerry Thompson<kerry@crypt.gen.nz>
 URL             : http://www.crypt.gen.nz/logsurfer/
 License         : BSD
 Section         : admin

I had a quick look at it and would like to make some suggestions:

- I: logsurfer: extended-description-is-probably-too-short

fixed.


- short description: could you change it to have it matchng
  "logsurfer is a" <short description>. (e.g. real-time system log
  monitoring).

fixed (but lintian does not allow to start with the package name)


- Running lintian with '-I' it get the following:

  I: logsurfer: spelling-error-in-binary usr/bin/logsurfer childs children
  I: logsurfer: extended-description-is-probably-too-short
  I: logsurfer: hyphen-used-as-minus-sign usr/share/man/man1/logsurfer.1.gz:136
  I: logsurfer: hyphen-used-as-minus-sign usr/share/man/man1/logsurfer.1.gz:141
  I: logsurfer: hyphen-used-as-minus-sign usr/share/man/man1/logsurfer.1.gz:145
  I: logsurfer: hyphen-used-as-minus-sign usr/share/man/man1/logsurfer.1.gz:162
  I: logsurfer: hyphen-used-as-minus-sign usr/share/man/man1/logsurfer.1.gz:166
  I: logsurfer: hyphen-used-as-minus-sign usr/share/man/man1/logsurfer.1.gz:168
  I: logsurfer: spelling-error-in-manpage usr/share/man/man1/logsurfer.1.gz expresion _expression_
  I: logsurfer: spelling-error-in-manpage usr/share/man/man1/logsurfer.1.gz expresion _expression_
  I: logsurfer: FSSTND-dir-in-manual-page usr/share/man/man4/logsurfer.conf.4.gz:249 /var/adm/
  I: logsurfer: hyphen-used-as-minus-sign usr/share/man/man4/logsurfer.conf.4.gz:300

all fixed except of  "FSSTND-dir-in-manual-page" 


  It would be great if you could add patches for the spelling errors
  and sent them to upstream to have them added in their new upstream
  releases.

done.


- logsurfer.conf manpage should go to section 5 'File formats and
  conventions eg /etc/passwd'.

done.


- Generally: For the first upload it would only be neede to have the
  changelog entry for the Initial upload. Furthermore use (Closes:
  #nnnn) for the closer. Otherwise the changes file will not include
  the Closes field to close #670875.

[1]: http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-desc


Thilo, as said I do not have time (at the moment) to fully go trough
the package, hope that someone can have a look too. It would be great
to have logsurfer in Debian.

I uploaded a new package (1.8-3):
http://mentors.debian.net/package/logsurfer

Thanks,
Thilo



Reply to: