[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#674789: RFS: amavisd-milter/1.5.0-5



Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "amavisd-milter" which fixes
some small cosmetic issues for Wheezy. As I know that there are packages
which need much more attention I tried to ease the review process as
much as possible.

 Package name    : amavisd-milter
 Version         : 1.5.0-5
 Upstream Author : Petr Rehor <rx@rx.cz>
 URL             : http://amavisd-milter.sourceforge.net/
 License         : BSD-like
 Section         : mail

It builds those binary packages:

  amavisd-milter - amavisd-new interface for milter-capable MTAs
  amavisd-milter-dbg - amavisd-new interface for milter-capable MTAs -
                       debugging symbols

To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/amavisd-milter

Alternatively, one can download the package with dget using this
command:

  dget -x http://mentors.debian.net/debian/pool/main/a/amavisd-milter/amavisd-milter_1.5.0-5.dsc

More information about amavisd-milter can be obtained from
http://amavisd-milter.sourceforge.net/.

Changes since the last upload:

amavisd-milter (1.5.0-5) unstable; urgency=low

  * debian/copyright:
    - Changed format specification URL from svn to released version 1.0.
    - Corrected file listing to use spaces instead of commas to comply with
      DEP-5 and satisfy lintian.
    - Added 2012 to the copyright years for the debian packaging.
  * debian/control:
    - Bumped Standards to 3.9.3 (changed to copyright-format 1.0).
    - Removed hardening-includes from Build-Depends and instead add a
      versioned build depedency on dpkg-dev >= 1.16.1~ (needed for getting
      hardened compile flags through dpkg-buildflags).
    - Build-Depend on debhelper >= 9.
    - Removed version constraints from Build-Depends, Depends and
      Recommends where requirements are already fulfilled in Squeeze.
  * debian/rules:
    - Switched from manual usage of hardening-includes to dpkg-buildflags.
  * debian/compat:
    - Bumped Version to 9.


Further information for potential sponsors:

 * package builds correct and clean according to:
   - cowbuilder --build --configfile pbuilderrc-amd64-sid.config
     amavisd-milter_1.5.0-5.dsc
   - qemubuilder --build --configfile qemubuilderrc-i386-sid.config
     amavisd-milter_1.5.0-5.dsc

 * package is built with full hardening enabled (CPPFLAGS are respected
   in the build process)

 * versioned dependencies on dpkg and debhelper are set according to
   minimal required versions to ease backporting

 * package is clean according to:
     lintian --show-overrides -E -I --pedantic
     amavisd-milter_1.5.0-5_amd64.changes
    (confirmed by mentors site)

 * standards version is 3.9.3

 * copyright is DEP-5 and clean according to:
     cme check dpkg-copyright

 * patches are DEP-3

 * software is currently running on i386 and amd64 testing machines


The following warnings will be seen while building the package:

configure: WARNING: Unrecognized options: --disable-maintainer-mode

 * AM_MAINTAINER_MODE in configue.ac was commented out by the upstream
   maintainer for the following reason:
   http://www.gnu.org/s/hello/manual/automake/maintainer_002dmode.html

/tmp/buildd/amavisd-milter-1.5.0/aclocal/missing: line 54: aclocal-1.10:
command not found
WARNING: `aclocal-1.10' is missing on your system.  You should only need
it if
         you modified `acinclude.m4' or `configure.ac'.  You might want
         to install the `Automake' and `Perl' packages.  Grab them from
         any GNU archive site.

/tmp/buildd/amavisd-milter-1.5.0/aclocal/missing: line 54:
automake-1.10: command not found
WARNING: `automake-1.10' is missing on your system.  You should only
need it if
         you modified `Makefile.am', `acinclude.m4' or `configure.ac'.
         You might want to install the `Automake' and `Perl' packages.
         Grab them from any GNU archive site.

/tmp/buildd/amavisd-milter-1.5.0/aclocal/missing: line 54: autoconf:
command not found
WARNING: `autoconf' is missing on your system.  You should only need it
if
         you modified `configure.ac'.  You might want to install the
         `Autoconf' and `GNU m4' packages.  Grab them from any GNU
         archive site.

/tmp/buildd/amavisd-milter-1.5.0/aclocal/missing: line 54: autoheader:
command not found
WARNING: `autoheader' is missing on your system.  You should only need
it if
         you modified `acconfig.h' or `configure.ac'.  You might want
         to install the `Autoconf' and `GNU m4' packages.  Grab them
         from any GNU archive site.

 * These warnings presumably result from patching configure and/or
   aclocal/ax_path_milter.m4 and are only present during the first
   build, subsequent builds do not show these problems.


Attached to this mail you will find a:
debdiff amavisd-milter_1.5.0-4.dsc amavisd-milter_1.5.0-5.dsc


I would be glad if someone uploaded this package for me.

Kind regards,
 Harald Jenny
diff -Nru amavisd-milter-1.5.0/debian/changelog amavisd-milter-1.5.0/debian/changelog
--- amavisd-milter-1.5.0/debian/changelog	2011-08-15 19:15:06.000000000 +0200
+++ amavisd-milter-1.5.0/debian/changelog	2012-05-27 15:52:17.000000000 +0200
@@ -1,3 +1,25 @@
+amavisd-milter (1.5.0-5) unstable; urgency=low
+
+  * debian/copyright:
+    - Changed format specification URL from svn to released version 1.0.
+    - Corrected file listing to use spaces instead of commas to comply with
+      DEP-5 and satisfy lintian.
+    - Added 2012 to the copyright years for the debian packaging.
+  * debian/control:
+    - Bumped Standards to 3.9.3 (changed to copyright-format 1.0).
+    - Removed hardening-includes from Build-Depends and instead add a versioned
+      build depedency on dpkg-dev >= 1.16.1~ (needed for getting hardened
+      compile flags through dpkg-buildflags).
+    - Build-Depend on debhelper >= 9.
+    - Removed version constraints from Build-Depends, Depends and Recommends
+      where requirements are already fulfilled in Squeeze.
+  * debian/rules:
+    - Switched from manual usage of hardening-includes to dpkg-buildflags.
+  * debian/compat:
+    - Bumped Version to 9.
+
+ -- Harald Jenny <harald@a-little-linux-box.at>  Sun, 27 May 2012 15:29:55 +0200
+
 amavisd-milter (1.5.0-4) unstable; urgency=low
 
   * debian/control:
diff -Nru amavisd-milter-1.5.0/debian/compat amavisd-milter-1.5.0/debian/compat
--- amavisd-milter-1.5.0/debian/compat	2011-08-15 19:15:06.000000000 +0200
+++ amavisd-milter-1.5.0/debian/compat	2012-05-27 15:52:17.000000000 +0200
@@ -1 +1 @@
-8
+9
diff -Nru amavisd-milter-1.5.0/debian/control amavisd-milter-1.5.0/debian/control
--- amavisd-milter-1.5.0/debian/control	2011-08-15 19:15:06.000000000 +0200
+++ amavisd-milter-1.5.0/debian/control	2012-05-27 15:52:17.000000000 +0200
@@ -2,16 +2,16 @@
 Section: mail
 Priority: extra
 Maintainer: Harald Jenny <harald@a-little-linux-box.at>
-Build-Depends: debhelper (>= 8), autotools-dev (>= 20100122.1), libmilter-dev, hardening-includes
+Build-Depends: dpkg-dev (>= 1.16.1~), debhelper (>= 9), autotools-dev, libmilter-dev
 Homepage: http://amavisd-milter.sourceforge.net/
 Vcs-Browser: http://anonscm.debian.org/gitweb/?p=amavisd-new/pkg-amavisd-milter.git
 Vcs-Git: git://anonscm.debian.org/amavisd-new/pkg-amavisd-milter.git
-Standards-Version: 3.9.2
+Standards-Version: 3.9.3
 
 Package: amavisd-milter
 Architecture: any
-Depends: ${misc:Depends}, ${shlibs:Depends}, libmilter1.0.1 (>= 8.14.3-9.5), amavisd-new (>= 2.4.3)
-Recommends: sendmail (>= 8.13.8-3) | postfix (>= 2.3.8-2+etch1)
+Depends: ${misc:Depends}, ${shlibs:Depends}, libmilter1.0.1 (>= 8.14.3-9.5), amavisd-new
+Recommends: sendmail | postfix
 Provides: amavisd-new-milter
 Breaks: amavisd-new-milter (<= 1:2.6.4-2)
 Replaces: amavisd-new-milter (<= 1:2.6.4-2)
diff -Nru amavisd-milter-1.5.0/debian/copyright amavisd-milter-1.5.0/debian/copyright
--- amavisd-milter-1.5.0/debian/copyright	2011-08-15 19:15:06.000000000 +0200
+++ amavisd-milter-1.5.0/debian/copyright	2012-05-27 15:52:17.000000000 +0200
@@ -1,4 +1,4 @@
-Format: http://svn.debian.org/wsvn/dep/web/deps/dep5.mdwn?op=file&rev=173
+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Upstream-Name: amavisd-milter
 Upstream-Contact: Petr Rehor <rx@rx.cz>
 Source: http://amavisd-milter.sourceforge.net/
@@ -7,8 +7,7 @@
 Copyright: 2005, Petr Rehor <rx@rx.cz>
 License: BSD-like
 
-Files: compat/fts_compat.h, compat/daemon.c, compat/mkdtemp.c,
-       compat/fts_open.c
+Files: compat/fts_compat.h compat/daemon.c compat/mkdtemp.c compat/fts_open.c
 Copyright: 1987, 1989, 1990, 1993, 1994, The Regents of the University of
            California
 License: BSD
@@ -52,7 +51,7 @@
  OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 
 Files: debian/*
-Copyright: 2009-2011, Harald Jenny <harald@a-little-linux-box.at>
+Copyright: 2009-2012, Harald Jenny <harald@a-little-linux-box.at>
 License: BSD-like
 
 License: BSD-like
diff -Nru amavisd-milter-1.5.0/debian/rules amavisd-milter-1.5.0/debian/rules
--- amavisd-milter-1.5.0/debian/rules	2011-08-15 19:15:06.000000000 +0200
+++ amavisd-milter-1.5.0/debian/rules	2012-05-27 15:52:17.000000000 +0200
@@ -1,7 +1,9 @@
 #!/usr/bin/make -f
 
-include /usr/share/hardening-includes/hardening.make
-EXTRA_LDFLAGS="-Wl,--as-needed"
+export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+DPKG_EXPORT_BUILDFLAGS = 1
+DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed
+include /usr/share/dpkg/buildflags.mk
 
 %:
 	dh $@ --with autotools_dev
@@ -9,9 +11,7 @@
 override_dh_auto_configure:
 	dh_auto_configure -- --prefix=/usr --mandir=\$${prefix}/share/man \
 	--sysconfdir=/etc --localstatedir=/var/lib/amavis \
-	--with-working-dir=/var/lib/amavis/tmp \
-	CFLAGS="$(CFLAGS) $(HARDENING_CFLAGS)" \
-	LDFLAGS="$(LDFLAGS) $(HARDENING_LDFLAGS) $(EXTRA_LDFLAGS)"
+	--with-working-dir=/var/lib/amavis/tmp
 
 override_dh_auto_install:
 	dh_auto_install --destdir=debian/amavisd-milter

Reply to: