[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#673096: RFS: figlet/2.2.4-1



* Jonathan McCrohan <jmccrohan@gmail.com>, 2012-05-16, 00:27:
 dget -x http://mentors.debian.net/debian/pool/main/f/figlet/figlet_2.2.4-1.dsc

One can also check out the package repository using git:

 git clone http://git.dereenigne.org/pkg-figlet.git

More information about figlet can be obtained from http://www.figlet.org.

Changes since the last upload:

figlet (2.2.4-1) unstable; urgency=low

 * New upstream release. (closes: #617422)
   - Relicensed as BSD; figlet can move back to main \o/
 * Improve packaging
   - Update S-V to 3.9.3
   - Bump Debhelper to v9
   - Switch to dpkg-source 3.0 (quilt) format

.diff.gz of the previous package touches some upstream files. What happened to this delta? (This should be documented in the changelog.)

I see you added makefile_set_debian_paths.patch, but this is not mentioned in the changelog.

What's up with figlist_man_hyphen-used-as-minus-sign.patch? It's not listed in debian/patches/series.

   - Update debian/copyright (closes: #436302)

You need to indent the enumerated list by an extra space. (Or alternatively: make all lines of the list indented by exactly one space, and then add (escaped) empty lines between the points.)

   - Fix moolets bashism (closes: #530082)

You introduced a dashism instead... Oh, and it you are at fixing this, please also fix the security hole (insecure creation of temporary files).

   - Move figlet manpage to alternatives system (closes: 403665)

I'd add a # here, for consistency with the other "closes" lines.

Shouldn't you use --slave here?

   - Add watchfile

Does ftp.figlet.org support only passive mode? (That would be very odd.) If
this is not the case, I would not put "opts=pasv" in debian/watch.

   - Remove references to depreciated figfonts(-cjk) packages

s/depreciated/deprecated/ maybe?

--
Jakub Wilk



Reply to: