Bug#664766: RFS: ember/0.6.2-1 [ITA]
On 04/09/2012 10:34 AM, Ansgar Burchardt wrote:
> tag 664766 + moreinfo confirmed
>
> Hi,
>
> sorry for taking a while, but here is the first round of comments:
>
> "Stephen M. Webb" <stephen.webb@bregmasoft.ca> writes:
>> ember (0.6.2-1) unstable; urgency=low
>>
>> * new upstream release (closes: #633854)
>> - removed dependency on libceguiogre-dev (closes: #629767)
>> * removed old unused build dependencies
>> * converted to 3.0 (quilt) source format, removed obsolete patches
>> * converted to use dh sequencer
>> * new maintainer: Debian games team (closes: #653970)
>> -added myself as uploader
> ^^^
> There is a space missing here.
Fixed.
>> * adjusted paths in installed launcher script to use defaults
>> * used xz compression in packaging
>> * debian/control: updated Standards-Version to 3.9.3
>> * debian/copyright: changed to computer-readable format (DEP-5)
>
> Comments about the packaging:
>
> Looks good, only some minor nitpicks:
>
> - debian/ember.1: "Debian GNU/Linux" should be changed to just "Debian".
Done.
> - Are the patches forwarded upstream?
Either reported as bugs or proposed pull requests.
> - d/rules: "find -exec rm" can be replaced with "find -delete"
> - d/rules: "find ." could be replaced with "find debian/tmp" as I
> understand you only want to remove duplicate COPYING files.
> - d/rules: "# force use of local version of tolua++ and newer libtool"
> doesn't seem related to the command below it.
Rules file adjusted.
> About copyright information:
>
> - src/components/ogre/environment/pagedgeometry/include/MersenneTwister.h:
> BSD-*3*-clause, also:
> "When you use this, send an email to: m-mat@math.sci.hiroshima-u.ac.jp
> with an appropriate reference to your work."
>
> This additional clause makes the license non-free ("postcardware"),
> see also the first example in question 12 of the [DFSGFAQ].
The postcard request was a part of the reference implementation that accompanied the original JACM paper by
Makoto Matsumoto and Takuji Nishimura. The included file is a reimplementation of the published algorithm by
Richard J. Wagner and does not include any of the reference implementation code. The "use this" in the quoted
clause refers to the reference implementation, which Richard J. Wagner consulted in creating his work, but does
not apply to his work. Rather, the clause in the license text of the header reads as follows.
// It would be nice to CC: wagnerr@umich.edu and Cokus@math.washington.edu
// when you write.
The wording in the reply to question 12 of the DFSGFAQ implies this is compliant.
> - FastDelegate.h: released under CPOL according to [FASTDELEGATE].
> See [CPOL] for the license. I haven't read the license text yet,
> please check it fulfills the DFSG requirements and is compatible with
> the other licenses.
The licensing on this is ambiguous at best. I, working with upstream, attempted to get clarification
from the author but so far have not been able to. I have replaced the code with an alternate implementation
that has a clear and acceptable license (boost).
> - DRGNURBSSurface.{h,cpp}: Copyright 1999 Intel Corporation.
> See file for license.
> - EmberPagingSceneManager/*: mostly LGPL-2+, not -2.1+
Adjusted.
> There are additional copyright holders and years of copyright should
> probably be updated as well. I noticed at least these, but didn't look
> that careful:
>
> - years of copyright need to be updated:
> Erik Hjortsberg <erik.hjortsberg@gmail.com>, (C) 2011
> (from EmberPagingTerrainObserver.h and others)
> - "Copyright (C) 2009 Manuel A. Fernandez Montecelo"
> - "Copyright (C) 2011 Erik Ogenvik" GPL-2+
> - src/components/ogre/gui/RenderedColourStringTextComponent.cpp:
> "contains code lifted from the CEGUI project". Has additional
> copyright holder and license.
> - "Copyright (c) 2000-2006 Torus Knot Software Ltd"
Adjusted. I found a couple of additional copyright holders I missed and added them.
Note that Erik Hjortsberg legally changed his name in July 2011 to Erik Ogenvik. All interest
in copyright under the original name should be deemed to be under the new name.
> About upstream code:
>
> - ./ember should probably use `set -e' and maybe also `set -u'.
> Also it's not possible to pass both --home and --debug.
> - ./ember.in seems to be no longer needed (it has the same contents as
> ./ember).
I have modified ember.in to better handle arguments and exit on error, as suggested.
This is being forwarded upstream.
The ember.in and the ember file generated from it are different. There is some variable substitution.
> - src/components/ogre/terrain/ICompilerTechniqueProvider.h:
> The header states "C++ Interface: ITerrainMaterialFinalizer" which
> looks like a copy-and-paste error. The include guards use
> EMBER_OGREVIEW_ITERRAINMATERIALFINALIZER_H as well.
> - spelling error: "To switch bach to attached mode, close the frame
> window with the dialog": bach -> back
I will forward these upstream.
These changes are commited and a new source package has been uploaded,
see http://mentors.debian.net/package/ember for details.
--
Stephen M. Webb <stephen.webb@bregmasoft.ca>
Reply to: