[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#669722: RFS: gnunet/0.9.2-1 [ITA]



Thanks for your work on the gnunet package.

On Sat, Apr 21, 2012 at 01:11:29PM +0200, Bertrand Marc wrote:
> dget -x http://mentors.debian.net/debian/pool/main/g/gnunet/gnunet_0.9.2-1.dsc

Why does the -dbg package depend on all other packages? Wouldn't it be
enough to depend on -common since all other packages (indirectly) depend
on -common?

Your copyright file uses something close to dep5. Now that dep5 is
finalized, could you add a format specification?

The (upstream) AUTHORS file lists a large number of contributors, but
debian/copyright only states a few of them. Maybe you could refer to the
AUTHORS file in a "Comment" paragraph?

Maybe you could also have a closer look at the individual files. For
instance po/sv.po lists the FSF as copyright owner. Also
src/include/plibc.h lists Nils Durner as copyright owner. And finally
debian/po/*.po list a number of other copyright owners.

Did you consider using dpkg-statoverride instead of chown to set up the
setuid binaries? That would allow an administrator to revoke certain
privileges (such as -transport-wlan on a system without wlan).

Also please be explicit about which binaries to chmod 4754. Certainly no
other package should create any /usr/bin/gnunet-helper-nat-foo, but if
it does things go badly wrong.

gnunet-server purge does not use debconf to determine which groups and
user to delete, but always deletes gnunet and gnunetdns even though I
might have changed them in postinst.

Since all packages (except gnunet-server) contain the very same
documentation and all packages (indirectly) depend on gnunet-common, you
could use dh_installdocs --link-doc and install the two READMEs for
gnunet-server to gnunet-common while still saving space.

Hope this helps

Helmut



Reply to: