[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#660519: Re[2]: Bug#660519: RFS: manaplus/1.2.2.19



Tue, 13 Mar 2012 13:28:21 +0800 от Paul Wise <pabs@debian.org>:
> On Tue, Mar 6, 2012 at 8:43 AM, andrei karas wrote:
> 
...
> > I removed most duplicates. Some left because this files accessed by physfs and
> > in physfs soft links not allowed. I allow it only for fonts enumeration.
> 
> I see, please file a bug on physfs upstream about this issue.
DIsabled soft links i think is security feature from physfs. Possible allow soft links,
but i dont want do this without big reason.

...
> > Some "dont" fixed other is by design in internal commands/events.
> 
> Ah, OK. If you want to add an explanation for that you can override
> the lintian warning and add a comment in the override file.
> 
It's only information message i prefer not add overrides to it.


> Here is an updated review:
> 
> In the registration process there is an option for Male or Female. I
> would suggest removing that or adding an Other category since both
> gender and biological sex have more options than that. Often people
> who do not fit into either of these categories will be very offended
> to have to label themselves as Male or Female.
I can't remove this because it required by server. But i add Other gender
in next version. New value can work only in Evol Online server after next
server update.

> 
> The initial download when logging into a server is quite big, is that
> a per-server thing like with web browsers or can it be added to
> Debian?
Yes, it's per server. Images, maps, tilesets, etc.
Possible in future i can package this files. Manaplus will use this files and
missing or new updates from server.

> 
> The first line in debian/copright should point at this URL instead now:
> 
> http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Fixed

> 
> You might want to switch to debhelper compat 9 so that manaplus gets
> built with security hardening compiler flags. This is especially
> important since manaplus is a network client.
Thanks, switched.

link here: http://mentors.debian.net/debian/pool/main/m/manaplus/manaplus_1.2.3.4-1.dsc

Reply to: