Bug#659498: Uploaded solarpowerlog-0.23-1 to d/m

[Tobias Frost <tobi@frost.de>]

Dear mentors,  

Please see my updated version 0.23-1, I just uploaded to d-m (and sf.net
-- note it will take some time until the watch file will work)

Of course as I try with every package I maintain -- it is lintian clean
and tested to be built using pbuilder. (manually as well on my buildbot
setup -- covering armel and i386 archs) 

The dsc file is located at:
http://mentors.debian.net/debian/pool/main/s/solarpowerlog/solarpowerlog_0.23-1.dsc

I handled this as an upstream release, as the benefits of the new
functionalities are not (only) for the packaging, but my other users as
well.

A quite improved daemon support is now available in 0.23 -- including a
rewrite of the init startup file. 

* start-stop-daemon -b no longer necessary, the needed infrastructure
has been implemented in solarpowerlog.

* also handles pid files of its own (init-file uses
/var/run/solarpowerlog/solarpowerlog.pid -- the subdirectory is due to
that solarpowerlog is supposed not to be run as a non-priviledged user,
but it would not have rights make the pid file directly in /var/run.

* handles log files (stderr, stdout --> files) including support for
reopening those files on a signal (to be nice to logrotate). The init
file uses /var/log/solarpowerlog/solarpowerlog.* for the same reasons as
the subdir for the pid file

* To be complete, a logrotate config-file is available. 

If you read that much, it seems that I caught your attention, so if you
a DD please consider sponsoring ;-) Otherwise, any feedback/ review is
of course highly appreciated.

Best regards,
Tobias Frost (coldtobi)


Am Freitag, den 17.02.2012, 12:48 +0100 schrieb Benoît Knecht:
>
> Sorry for the late reply, spare time was quite spare the last days...
>
>> Hi Tobias,
>> 
>> As promised, here's my review of your package:
>> 
>>     You also note there that start-stop-daemon is taking care of running
>>     solarpowerlog in the background, but according to
>>     start-stop-daemon(8), "this is a last resort, and is only meant for
>>     programs that either make no sense forking on their own, or where
>>     it's not feasible to add the code for them to do this themselves";
>>     since your program can put itself in the background, you should
>>     rather use that possibility. This way, it will also make sense
>>     checking the exit status of start-stop-daemon in do_start in the
>>     init script, because if you use its '-b' option, it can't determine
>>     if the process failed to execute.
>
> Yes, the daemon support of solarpowerlog is a mixture of barely tested,
> incomplete, limited, you name it.. At least up to version 0.22, as I
> worked on this with the last commit to my development branch. In other
> words, 0.23, which I plan to release soon, will get rid of the hacks you
> mentined above.  


coldtobi