Bug#662026: RFS: shotdetect/1.0.86-1 [ITP]
Giulio Paci wrote:
> thank you for your comment. I updated the package, adding the missing
> libxslt1-dev dependency and fixing a couple of other minor issues.
A few things to look into:
- Your man page is quite thin. Please expand it using full words
instead of abbreviations (img, thumb, etc.) and full sentences. Try
explaining what each option does.
For instance, '-o' takes a path as an argument; to what, a directory
or a file? What happens if both and XML file and a thumbnail are to
be generated?
Likewise, the description of '-s' doesn't help me at all. What is
the range of the threshold? Is it a float or an integer? What does
it represent?
For '-w', what is a waveform?
You also need to escape the space between 'January,' and '2012'.
- debian/patches/compilation_fixes.patch contains a lot of whitespace
fixes, most of them in comments; please remove those to make it
easier to understand.
- Why are you putting your package in contrib/misc? As far as I can
see, it doesn't depend on a non-free package, so the video section
seems more appropriate.
- ltmain.sh is GPL-2+, and the FSF is its copyright holder; this
should be reflected in debian/copyright. Use
licensecheck -r --copyright .
to make sure you're not missing anything else.
- I don't think you should install AUTHORS; it contains a single name,
and that information is in debian/copyright already.
The NEWS file seems pretty useless as well.
The README file is just plain confusing.
Cheers,
--
Benoît Knecht
Reply to: