Bug#661665: RFS: openastro.org/1.1.25-2 [ITP]
I don't intend to sponsor this package, but here's the review:
* Paul Elliott <pelliott@blackpatchpanel.com>, 2012-02-28, 18:32:
dget -x http://mentors.debian.net/debian/pool/main/o/openastro.org/openastro.org_1.1.25-2.dsc
(Please see my reply to #661664. Many things I noted there applies to
this package, too. I won't mention them here again.)
Lintian emits:
P: openastro.org source: debian-control-has-unusual-field-spacing line 5
"debhelper (>= 7.0.50~)" instead of "debhelper (>= 7.0.50)" would be a
bit more friendly to backporters.
With dh_python2, you should use X-Python-Version, not XS-Python-Version.
Also, remove XB-Python-Version.
The package is arch:all, so there's no point including ${shlibs:Depends}
in Depends, as it won't be ever substituted.
Is there a reason for patching _comments_ in
0005-rename-openastro.py-as-required-by.patch? That looks strange.
When built with restrictive umask (e.g. 027), the package FTBFS:
| dh_fixperms
| chmod -x debian/openastro.org/usr/share/openastro.org/icons/aspects/*.svg
| chmod: debian/openastro.org/usr/share/openastro.org/icons/aspects/0.svg: new permissions are rw-r--r-x, not rw-r--r--
| chmod: debian/openastro.org/usr/share/openastro.org/icons/aspects/120.svg: new permissions are rw-r--r-x, not rw-r--r--
| chmod: debian/openastro.org/usr/share/openastro.org/icons/aspects/135.svg: new permissions are rw-r--r-x, not rw-r--r--
| chmod: debian/openastro.org/usr/share/openastro.org/icons/aspects/144.svg: new permissions are rw-r--r-x, not rw-r--r--
| chmod: debian/openastro.org/usr/share/openastro.org/icons/aspects/150.svg: new permissions are rw-r--r-x, not rw-r--r--
| chmod: debian/openastro.org/usr/share/openastro.org/icons/aspects/180.svg: new permissions are rw-r--r-x, not rw-r--r--
| chmod: debian/openastro.org/usr/share/openastro.org/icons/aspects/30.svg: new permissions are rw-r--r-x, not rw-r--r--
| chmod: debian/openastro.org/usr/share/openastro.org/icons/aspects/45.svg: new permissions are rw-r--r-x, not rw-r--r--
| chmod: debian/openastro.org/usr/share/openastro.org/icons/aspects/60.svg: new permissions are rw-r--r-x, not rw-r--r--
| chmod: debian/openastro.org/usr/share/openastro.org/icons/aspects/72.svg: new permissions are rw-r--r-x, not rw-r--r--
| chmod: debian/openastro.org/usr/share/openastro.org/icons/aspects/90.svg: new permissions are rw-r--r-x, not rw-r--r--
| make[1]: *** [override_dh_fixperms] Error 1
Then, if I try to build it again it fails with:
| dpkg-source -b openastro.org-1.1.25
| dpkg-source: info: using source format `3.0 (quilt)'
| dpkg-source: info: building openastro.org using existing ./openastro.org_1.1.25.orig.tar.gz
| dpkg-source: warning: ignoring deletion of file openastro.py
| dpkg-source: warning: ignoring deletion of file openastromod/swiss.py.orig
| dpkg-source: warning: executable mode 0700 of 'openastro' will not be represented in diff
| dpkg-source: info: local changes detected, the modified files are:
| openastro.org-1.1.25/openastro
| dpkg-source: info: you can integrate the local changes with dpkg-source --commit
| dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/openastro.org_1.1.25-2.diff.4r9kOA
| dpkg-buildpackage: error: dpkg-source -b openastro.org-1.1.25 gave error exit status 2
Are the Python modules included in this package supposed to be used by
other software? If yes, then the package name should be
python-openastromod. If no, then please move them to a private
directory.
Version number passed to distutils.core.setup() contains a trailing
newline. Please report his to upstream.
--
Jakub Wilk
Reply to: