[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: Non-maintainer upload for rdiff-backup

* Carlos Alberto Lopez Perez <clopez@igalia.com>, 2012-01-03, 15:30:
* http://mentors.debian.net/package/rdiff-backup

$ dget http://mentors.debian.net/debian/pool/main/r/rdiff-backup/rdiff-backup_1.2.8-7.dsc

Version number for NMU is wrong, and lintian would tell you that:

W: rdiff-backup source: source-nmu-has-incorrect-version-number 1.2.8-7

What is the point of 02_python_2.6_deprecationwarning? The default version is 2.7, which has all deprecation warnings disabled by default.
Rather than:

	if map(int, sys.version.split()[0].split('.')[:2]) >= [2, 6]:

you could write:

	if sys.version_info >= (2, 6):

Though I don't understand why do you need a version check at all. The subprocess module has been available since 2.4, and even oldstable has 2.5 as the default version.

Jakub Wilk

Reply to: