[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: unetbootin



Hi Muneeb,

On 2011-12-08 03:50, Muneeb Shaikh wrote:
>   dget -x http://mentors.debian.net/debian/pool/main/u/unetbootin/unetbootin_565-1.dsc

1) you bumped debhelper build-dependency version from 7 to 8, why?
   Also, changes like this should be always documented in
   debian/changelog.

2) you removed a build-dependency version of libqt4-dev (which was ">=
   4.2"). That's fine, but should me mentioned in the debian/changelog,
   preferrably with a short explanation why it should be safe.

> The Git repository us at:
> http://git.debian.org/?p=collab-maint/unetbootin.git;a=summary

By the way, it's good you use a repository, but it's not good you merged
all your debian/ changes into a single commit which is not easier to
review than a .dsc.

-- 
Eugene V. Lyubimkin aka JackYF, JID: jackyf.devel(maildog)gmail.com
C++/Perl developer, Debian Developer


Reply to: