Re: RFS: bino

[Daniel Schaal <farbing@web.de>]

Am Mittwoch, 28. September 2011, 17:22:35 schrieb Dominique Dumont:
> Le Wednesday 14 September 2011 06:44:11, Daniel Schaal a écrit :
> > I uploaded an updated package to http://mentors.debian.net/package/bino
> 
> Here are some comments:

Thanks for the review.

> - debian/copyright: In fact the "simple All-Permissive License" you mention
>   is very close to BSD 2-clause license [1]. To respect Dep-5 syntax, you
>   should use a short name in license field. I.e not:

It seems the license text comes from [1], which calls it All-permissive 
Copying License, but I changed it to BSD-2-clause-like as it is probably 
clearer.

> 
> - debian/control: 'config-edit -appli dpkg -ui none' reports some issues
>   on some versioned dependencies:
> 
>   Warning in 'control source Build-Depends:3' value 'libavcodec-dev (>= 
> 0.7)': unnecessary versioned dependency:
> >= 0.7. Debian has etch-security -> 0.cvs20060823-8+etch1; etch ->
> >0.cvs20060823-8+etch1; lenny ->

Fixed Build-Depends to also include the epoch.

> - "lintian -i -I ../bino_1.2.0-1_amd64.deb" reports:
>   I: bino: hyphen-used-as-minus-sign usr/share/man/man1/bino.1.gz:201
>   I: bino: hyphen-used-as-minus-sign usr/share/man/man1/bino.1.gz:203
>   I: bino: possible-documentation-but-no-doc-base-registration
> 
>   Is it possible to fix these issues ?

Added patch to escape hyphens in man page (will see if I can get this 
upstream), and added a doc-base control file.

I also bumped the debhelper compat to 9 to get the values from dpkg-buildflags

New package uploaded to [2]

Thanks,
Daniel Schaal

[1] http://www.gnu.org/s/hello/manual/texinfo/All_002dpermissive-Copying-
License.html
[2] http://mentors.debian.net/package/bino