[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: fribid



Hi

On 2011-07-11 23:46, Samuel Lidén Borell wrote:
> 
>> Please recheck with lintian, I'm getting a couple of warnings here:
>>  W: fribid source: debian-rules-missing-recommended-target build-arch
>>  W: fribid source: out-of-date-standards-version 3.9.1 (current is 3.9.2)
>>
>> Please check debian/copyright.  Seems like you are missing some entries...  e.g:
>>  ./client/secmem.h:  Copyright (c) 2010 Linus Walleij <triad@df.lth.se>
>>  ./client/pkcs11.c:  Copyright (c) 2010 Marcus Carlson <marcus@mejlamej.nu>
>>  ./client/pkcs11.c:  Copyright (c) 2010 Henrik Nordström <henrik@henriknordstrom.net>
>>  ./client/pkcs12.c:  Copyright (c) 2010 Marcus Carlson <marcus@mejlamej.nu>
>>  ./npapi/jni_md.h: * Copyright (c) International Business Machines
            ^^^^^^^^

This looks like a file from Java, namely:

openjdk-6-jdk: /usr/lib/jvm/java-6-openjdk/include/linux/jni_md.h

Since the package does not build-depend on any known Java in Debian, I
assume it uses the embedded version rather than the one shipped in
(various) Debian packages?
  Looks like xulrunner is shipping one as well, you may want to use that.

xulrunner-dev: /usr/include/xulrunner-1.9.1/stable/jni_md.h
xulrunner-dev: /usr/include/xulrunner-1.9.1/unstable/jni_md.h

>>
>> Regards,
>>  Ruben
> 
> 
> Thanks for your comments :)
> 
> I have fixed these problems and some others, and uploaded a new version (also a new upstream version):
> 
> http://mentors.debian.net/debian/pool/main/f/fribid/fribid_0.3.1-1.dsc
> 

>From the d/rules:

cp npapi/MPL-1.1.txt $(CURDIR)/debian/fribid/usr/share/doc/fribid/MPL
cp npapi/NPL-1.1.txt $(CURDIR)/debian/fribid/usr/share/doc/fribid/NPL

These ought to be redundant as you have to document them in d/copyright
anyway.

Anyhow, not much of a packager for browser-related stuff so I have not
checked anything beyond this.

~Niels


Reply to: