Re: RFS: cmsmadesimple
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hello Michael,
On 07/10/11 05:03, Michael Tautschnig wrote:
> Hi,
>
> Sorry for taking so long for anyone to respond. Indeed this is a very nice
> example of making proper use of existing Debian packages, despite upstream
> shipping all the duplicate code. The only remaining point is
> modules/Printing/tcpdf/fonts/: it wouldn't occur to me as a surprise to find
> this freefont code to be part of some of the *-freefont packages!?
>
indeed I didn't think about the fonts, I will look into it for the next version
though.
> One suggestion for the package install procedure, though: why do you first
> install all the files and afterwards remove them again via an override in
> debian/rules? Wouldn't it be much cleaner to only install the desired files?
>
I preferred this method for a couple of reasons, firstly because I think the
code for installing all of the folders separately would be much bigger and also
because this makes the packaging a bit less error prone. If I do all of the
install in the .install file, I would have to have a lot of lines (because I
have to omit the translation files and the shared libs) and if upstream adds any
files or folders, these might not get included without changing the install file.
> Anyhow, built, signed, and uploaded. But as a new upstream version is already
> available, there is a chance for you to update the packaging as well :-)
>
Thank you very much! I will update the package ASAP.
> Thanks a lot for your work,
> Michael
>
- --
Best regards,
Mit freundlichen Grüßen,
Cristian Henzel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBCAAGBQJOGXS6AAoJENnza/EQjIwPOXwP/A5DEHeaQ2pFYknaOMq8EYi3
fjLNl3TOKV5ZfOlHnNfnj2jvt8cbWrQH0UK7mWB5u/G029yGWDwQpQmgR0ZQD/3f
NW3MIP2px3T73o9LXQYyUAXExD/EakCEew5+emmT80ONvP13wEXU+RyzIzL/9gZ+
2zFOC7m0EFzxv9QswqiSOV8GWjUCgj/mSJJVG0Rs7W9vAZWRzoY/thvxh68f8MhC
HxH6h9yxl+cDoq5pZSS9iDsDXReM21l5BrxTDj0Npprxmk+f94PayiISKMDUCbbm
4O4yEqgBc/tfjKidySbGApv53ZZdfY6MbHtKQDOo6hZrM39LiXnF5EkwxpUoNuxw
cVs+f8MeqsiRyk93lZKr06zn7CzmVIk3W/Sr4m8njBowm+9aeUIoedi2TfoFoRuQ
Ngot91OOt4SEe2wU4bzaKGp3opTgM6pJFTRCmyJ+jFwTHSgTf6d62NChCkCugM1s
MszpKYPrENKUzpN4LNeL3IgknxEoeBjy24LQmYnaGtZenmmV0WAkE+mqkb2t483B
7JQt5kVIWQdQ1k7NGhkRrSrpUw3iNgCx50/Qx+/SEtSCoYmW4A4R6FnDTuWjambB
FceqQIjnc21b4hIdnocYnfFUU+9uwXkuP5qK6teuCtXEEND2qRLdNt7OWhEz8rGU
0CzpqRjyPmMIXgeZYSit
=NvKX
-----END PGP SIGNATURE-----
Reply to: