[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: sxiv (updated package)



Hi Paul

2011/7/7 Paul Wise <pabs@debian.org>
On Thu, Jul 7, 2011 at 7:05 PM, Daniel Echeverry wrote:

> sxiv       - simple X image viewer

The package is already uploaded by kilian, but here is a review of
things you could fix:

The upstream README.md file contains installation information that
isn't relevant to users of binary packages. Looking at the rest of the
content, that is covered by the manual page. IIRC README.md files are
used by github to make a web page. I would suggest dropping this file
from the Debian package

Removed! 


In the watch file, I would suggest ([\d\.]+) instead of (.*) which
will prevent getting random branches in the DEHS output.


Done! 


Looking at the upstream source code (config.h), a line like this in
debian/control might be appropriate:

Suggests: libjpeg-progs, imagemagick

 
Done!
 
--
bye,
pabs

http://wiki.debian.org/PaulWise



Please check out:
http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_0.8.2-3.dsc

Thank you very much!
 
--
Epsilon
http://www.rinconinformatico.net
http://www.fitnessdeportes.com
http://www.dragonjar.org
Linux user: #477840
Debian user


Reply to: