Hi Andrew, On Thu, 2011-06-30 at 00:30 +0300, Andrew O. Shadoura wrote: > On Wed, 29 Jun 2011 16:11:56 -0500 > Elías Alejandro <ealmdz@gmail.com> wrote: > > > I am not a DD, so I can't sponsor your contribution. I'm sorry. But > > here my fast review about your package: > > > 1. Bump Standards-Version to 3.9.2 > > Yes, I know. > > > 2. Maybe you can use debhelper version 8 under: debian/compat, > > debian/control > > Possibly. > > > 3. debian/copyright: please use DEP-5 format[0] > > I don't think it's a good idea. Why not? > > 4. Newest version on remote site is 0.03 > > I know, I'm the upstream. > > > 5. Lintian issues (lintian -iI --pedantic): > > W: tnat64: package-name-doesnt-match-sonames libtnat64-0.1 > > W: tnat64: non-dev-pkg-with-shlib-symlink usr/lib/libtnat64.so.0.1 > > usr/lib/libtnat64.so I: tnat64: no-symbols-control-file > > usr/lib/libtnat64.so.0.1 > > Isn't really relevant, as this is a LD_PRELOAD-able library. What's the one to do with the other here? If it's a real shared library it can and even should be split out to a lib package. The possibility to preload it doesn't really make more sense to me than linking it in statically I guess. But maybe I just missed your point. -- Best regards, Kilian
Attachment:
signature.asc
Description: This is a digitally signed message part