Re: RFS: dsniff (updated package)

[William Vera <billy@billy.com.mx>]

Hi!

On Mon, Jun 27, 2011 at 4:07 AM, Kilian Krause <kk@verfaction.de> wrote:
> Hi William,
>
>
> 1. README.source still talks about dpatch despite changelog reads
> package converted.

Updated for quilt

>
> 2. libx11-6 is now always pulled in via Depends. You can safely edit
> README.Debian to reflect this or rather remove it entirely.

It's in Recommends because it's used by 'webspy' not properly by 'dnisff'
IMHO it's fine how is in README.Debian

>
> 3. in debian/rules why is
> override_dh_auto_configure:
>        dh_auto_configure -- --host=$(DEB_HOST_GNU_TYPE) --build=
> $(DEB_BUILD_GNU_TYPE) --prefix=/usr --mandir=\$${prefix}/share/man
> --infodir=\$${prefix}/share/info
>
> needed and different from the debhelper7 automagic configuration?

Not really, droped

>
> Apart from this fine for upload into Debian IMHO.
>

Thanks for you review, the packages is updated:
http://mentors.debian.net/debian/pool/main/d/dsniff/dsniff_2.4b1+debian-21.dsc

> --
> Cheers,
> Kilian
>
>

Regards

-- 
William Vera <billy@billy.com.mx>
PGP Key: 1024D/F5CC22A4
Fingerprint: 3E73 FA1F 5C57 6005 0439  4D75 1FD2 BF96 F5CC 22A4