[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: [QA Upload] netsend



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Mats Erik and Sven,

On 02.06.2011 12:42, Mats Erik Andersson wrote:
>> >> Reading the bug logs I'd favour an upload using the 'new upstream'
>> >> version.
> >
> > The bug #586037 is sufficient to motivate the removal of a package
> > built from the old source. All the more so in the absence of IPv6
> > capabilities.
> >
Fair enough. I just didn't feel comfortable to package an entire new
upstream source for a QA upload.

Glad to see you worked on that already Mats, therefore I updated my
package and merged our approaches. I attached a diff outlining all
changes in debian/ I made.

Note I removed you and other people interested from Maintainer/Uploaders
and left QA as I originally suggested. If you still want to adopt the
package, I'd suggest you to change bug #487339 to ITA and seek for
sponsors for your first maintainer upload, with or without the DDs
originally interested to join you.

I didn't commit my changes to your VCS, I can do if you want, as I'm a
member of collab-maint myself.


The updated package can be found on mentors.debian.net:
- - URL: http://mentors.debian.net/debian/pool/main/n/netsed
- - Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- - dget
http://mentors.debian.net/debian/pool/main/n/netsed/netsed_1.00b-1.dsc


(sorry Mats, I mailed you instead of the list right before)

- -- 
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJN536fAAoJEMcrUe6dgPNtTwgP+gLF/v3WzK2jZzpE1vTZsUT7
uI5VWhy87BzoWVJ/4GFxMeVNCWjnWeVEXlSlYxjYoROOmxToUmfk9J2QXKp2XyLG
27YIl8f0PGy6LeFX4BT1jGz3eRMT5zun+x+afFyoLS1oZQFCEb4TccDnD7Cq8hc6
jVyRmibz8tlOvR+laEDMS5UBMm72hLiDhigjIsFROvt+82Py5KjHbfPKg+yY2RiR
zLUK7nGMmAN+14SyuqUaHablPQG4XaHR2zXXg6oBPeL6OOt8UyPnUdOrkwk4t9SP
bBxf/CuOaXlf/OW855x/AvKi7f5F2kZ6QHeQP0AD7PfPSF/Te0Vv2bGd6qlUXqam
DVfFRgHS1Oh2j4hUNtc8E3ltzCbP7iobm7DdR8+Lg6mQgZ9kU89enC64ihrg/qd8
k9z5LTbe0uzv2yuHwOsSPU3T+V/cpePgv/9CuqDa6SI5A8F4JL3LiobslgyOVuhd
8h2VcEzVZbOZ3/pD45xnhAld/njvBkqp2B0Xc33AahgJdgp94LgEBkosejiuSP+m
a45Fvh2NFm5l9odmSXYuFTp2AU2vMq4Avwgj3LVnaTs6u+3u+wAA+lU2DXUSHqrM
T0/VMI60OLckailpdeNAJ2hcGXz9fBF67lzGwQSTByZ1NMchQttWZnC6OsJVnGC0
btwox55AFx234SO05szT
=F6g9
-----END PGP SIGNATURE-----
diff -ruN netsed/debian/changelog netsed-new/debian/changelog
--- netsed/debian/changelog	2011-06-02 13:21:52.000000000 +0200
+++ netsed-new/debian/changelog	2011-06-02 13:54:14.000000000 +0200
@@ -1,43 +1,31 @@
-netsed (1.00b-1) UNRELEASED; urgency=low
+netsed (1.00b-1) unstable; urgency=low
 
-  [ Mats Erik Andersson ]
-  * New upstream release.
-  * debian/control:
-    + Add M E Andersson as uploader.
-    + Standards-Version: 3.9.1.
-    + Build dependency: debhelper (>= 7.0.50~), ruby.
-    + Add ${misc:Depends} to binary package dependency.
-    + Homepage stanza.
-    + Vcs-*: New stanzas.
-  * debian/compat:
-    + New file, level 7.
+  * QA upload.
+  * New upstream release from a new maintainer and thus having a new source
+  * Fix "netsed executes a tight non-blocking loop.": Change to new upstream 
+    source (Closes: #586037)
+  * Orphaning package, assign package to the QA team. Maintainer is MIA.
+  * Switch to dpkg-source 3.0 (quilt) format
+  * Start rules file from scratch: use dh 7 mode, make
+    use of various debhelpers (dh_installdocs, dh_installdirs, ...)
+  * Set compat and dependency to debhelper 8
+  * Bump standards, package should comply to all requirements now.
+
+  [Mats Erik Andersson]
+
+  * debian/patches/:
+    + 01-cflag_inclusion.diff: Sense any exported CFLAGS.
+    + 02-ftbfs_kfreebsd.diff: Resolve FTBFS for GNU/kfreebsd.
   * debian/copyright:
     + Rewritten according to DEP-5.
-  * debian/rules:
-    + Simplified formulation based on 'dh' with an 'override_dh_install'.
-  * debian/source/format:
-    + New file, format "3.0 (quilt)".
   * debian/watch:
     + New file.
-  * debian/netsed.docs:
-    + New file.
-  * debian/patches/:
-    + 01-cflag_inclusion.diff: Sense any exported CFLAGS.
-    + 02-ftbfs_kfreebsd.diff: Resolve FTBFS for GNU/kfreebsd.
-  * [lintian] debian/netsed.1: spelling-error-in-man-page
-
- -- Mats Erik Andersson <mats.andersson@gisladisker.se>  Sat, 11 Sep 2010 11:36:46 +0200
-
-netsed (0.02a-1) UNRELEASED; urgency=low
-
-  * Adopting package.
-  * New upstream release.
-    + Uses select() rather than a busy loop. (Closes: #586037)
-    + Attempts to resolve hostnames. (Closes: #397420)
   * debian/control:
-    + Add self to Uploaders.
+    + Homepage stanza.
+    + Vcs-*: New stanzas.
+    + Add ruby build dependency
 
- -- Tim Retout <diocles@debian.org>  Sat, 19 Jun 2010 21:49:24 +0100
+ -- Arno Töll <debian@toell.net>  Thu, 02 Jun 2011 13:51:42 +0200
 
 netsed (0.01c-2.1) unstable; urgency=low
 
diff -ruN netsed/debian/compat netsed-new/debian/compat
--- netsed/debian/compat	2011-06-02 13:21:52.000000000 +0200
+++ netsed-new/debian/compat	2011-06-02 01:12:23.000000000 +0200
@@ -1 +1 @@
-7
+8
diff -ruN netsed/debian/control netsed-new/debian/control
--- netsed/debian/control	2011-06-02 13:21:52.000000000 +0200
+++ netsed-new/debian/control	2011-06-02 13:42:29.000000000 +0200
@@ -1,10 +1,9 @@
 Source: netsed
 Section: net
 Priority: optional
-Maintainer: Lenart Janos <ocsi@debian.org>
-Uploaders: Tim Retout <diocles@debian.org>, Mats Erik Andersson <mats.andersson@gisladisker.se>
-Standards-Version: 3.9.1
-Build-Depends: debhelper (>= 7.0.50~), ruby
+Maintainer: Debian QA Group <packages@qa.debian.org>
+Standards-Version: 3.9.2
+Build-Depends: debhelper (>= 8.0), ruby
 Homepage: http://silicone.homelinux.org/projects/netsed/
 Vcs-Git: http://git.debian.org/git/collab-maint/netsed.git
 Vcs-Browser: http://git.debian.org/?p=collab-maint/netsed.git
@@ -12,20 +11,18 @@
 Package: netsed
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
-Description: The network packet altering stream editor
+Description: Network packet altering stream editor
  NetSED is small and handful utility designed to alter the contents of
  packets forwarded thru your network in real time. It is really useful
- for network hackers in following applications:
+ for network packet alteration, forging and manipulation. NetSED supports:
  .
    * black-box protocol auditing - whenever there are two or more
      proprietary boxes communicating over undocumented protocol (by
      enforcing  changes in ongoing transmissions, you will be able to
      test if tested application is secure),
- .
    * fuzz-alike experiments, integrity tests - whenever you want to test
      stability of the application and see how it ensures data integrity,
- .
    * other common applications - fooling other people, content filtering,
-     etc, etc - choose whatever you want to.
+     and so on - choose whatever suits your requirements.
  .
  It perfectly fits ngrep, netcat and tcpdump tools suite.
diff -ruN netsed/debian/dirs netsed-new/debian/dirs
--- netsed/debian/dirs	1970-01-01 01:00:00.000000000 +0100
+++ netsed-new/debian/dirs	2011-06-02 01:28:25.000000000 +0200
@@ -0,0 +1 @@
+usr/bin/
diff -ruN netsed/debian/docs netsed-new/debian/docs
--- netsed/debian/docs	1970-01-01 01:00:00.000000000 +0100
+++ netsed-new/debian/docs	2011-06-02 13:51:25.000000000 +0200
@@ -0,0 +1,3 @@
+README
+NEWS
+TODO
diff -ruN netsed/debian/manpages netsed-new/debian/manpages
--- netsed/debian/manpages	1970-01-01 01:00:00.000000000 +0100
+++ netsed-new/debian/manpages	2011-06-02 01:30:29.000000000 +0200
@@ -0,0 +1 @@
+debian/netsed.1
diff -ruN netsed/debian/netsed.docs netsed-new/debian/netsed.docs
--- netsed/debian/netsed.docs	2011-06-02 13:21:52.000000000 +0200
+++ netsed-new/debian/netsed.docs	1970-01-01 01:00:00.000000000 +0100
@@ -1,2 +0,0 @@
-README
-TODO
diff -ruN netsed/debian/rules netsed-new/debian/rules
--- netsed/debian/rules	2011-06-02 13:21:52.000000000 +0200
+++ netsed-new/debian/rules	2011-06-02 13:58:43.000000000 +0200
@@ -1,11 +1,18 @@
 #!/usr/bin/make -f
+# -*- makefile -*-
+
+# debian/rules for netsed by Arno Töll <debian@toell.net>
+# Written from scratch to adapt for debhelper 8
+
+# Uncomment this to turn on verbose mode.
+# export DH_VERBOSE=1
+
+pkg = netsed
 
 %:
 	dh $@
 
-override_dh_install:
-	dh_installman debian/netsed.1
-	dh_installchangelogs NEWS
-	# The single executable.
-	dh_install netsed usr/bin/
-	dh $@
+
+override_dh_auto_install:
+	install $(pkg) debian/$(pkg)/usr/bin	
+	

Reply to: