[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: scriptutils



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Sebastien,

I took a brief look in your package (however I can't sponsor you anyway).

On 10.05.2011 16:33, wayana@gmx.com wrote:
> * License : Apache 2 Section

* You claim it would be licensed GPL-3 in your debian/copyright file.
Please fix this to indicate, whatever applies to your project (as you
are upstream as well). While fixing you could use DEP-5 as well [1].

* Your package FTBS, e.g. see:

STDERR    date: invalid date `Fr 23. Sep 03:52:49 CEST 1983'$
STDERR    datediff: error(s) reported$
STATUS    1
ASSERT    <status eq 0>
ERROR     assertion <status eq 0> failed
FAILED    test_random_dates
make[1]: ***
[/home/arno/foo/scriptutils-1.4.0/target/test/datediff.passed] Error 1
make[1]: Leaving directory `/home/arno/foo/scriptutils-1.4.0'
make: *** [debian/stamp-makefile-check] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2


* Your control file is incomplete. Please add a more verbose description
and put some actual content to the synopsis. Remember, the synopsis line
is a very short description to advertise what your program is
about. Make it as useful as possible to the reader

* VCS-* fields should point to the Debian VCS where the package is
managed, not upstream, even if this is your own project.

* Your standards version is outdated, please bump to 3.9.2

* I fail to see, why your package would need priority "standard". See
[2]. Moreover this is a policy violation as of § 2.5 since
your dependencies have lower priorities (e.g. gawk).

* Your debian/changelog is incomplete (dude, you didn't even even
replace the bug #XXXXX template)

* Your debian/docs looks wrong. Maybe you wanted to put a newline
between the entries.

* You miss man pages for some of your utilities, the existing ones are
mostly incomplete.

* Your patches are pointless. If you consider this a bug, fix it
upstream but don't change your local source tarball data without good
reason. By the way: The DEP-3 header puts in there automatically, aren't
supposed to keep as they are. Fill out the suggested fields [3]. In fact
it is considered a bad style relying on the quilt package format to
track your changes. Also they shouldn't probably named after your Ubuntu
PPA version ...

* You miss a watch file  [4].

* There are perhaps more thing to add, but I could not build your package.

[1] http://dep.debian.net/deps/dep5/
[2] http://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities
[3] http://dep.debian.net/deps/dep3/
[4] http://www.debian.org/doc/debian-policy/ch-source.html#s-debianwatch

- -- 
with kind regards,
Arno Töll
GnuPG Key-ID: 0x9D80F36D

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJNyV6dAAoJEMcrUe6dgPNtdCkP/1u2QFIMBLnS3rwhZJG8k6fm
8gAwVyyp+ssiDW320C4eo9fiPKmFbSFTumyKjBFNxXn6Qb0LspUobs4r/JuQ/273
uLJ9BDhxlEqbq+76oV5LLBeFCAEztWsBQMmPN/XjKqiN9xzXtPsJlKOVpWbF/3Pk
UvMuoz6BRKKcDQ3utvttyadar4SIS56JS0NW6iBI9keO6ixO9+g0Kz/LneCZA+l0
g1elczUqhjTU0oN1rVH2iSEC/zwLA4zjWeO+5QitmInOgPn7dloZUMzsGgYJJikB
6IKrC9rA57yfqfRCGYuAIc4jW57PE9UmqMkoXA9akI7vx7EpOi4svEIDnpAr/lCo
d+3njGG2A34ZFEgEdbXn125N+cbbpcuQguXiQqobFVTrVscXK5D2Cs1LnB2kWUtK
gvwSvtJb/r8VBruPKVytpfbwcL8Nlnw4mxURzVwtocIzVAKovuVdqeUF2cbyKcKb
aXhslMKGNfW54J9dcZv2wyKyQKtHR/sko3A/NseefQTbKlCWoUK689R/QM588uqz
bAMQNS5nQXWM1Nh+hkBK5A7CEDw8Oxrx37BBCT4uyOLsdE2z966VKh2u5cuS8BvU
SE9y2o8FRutgzlSO+HM1GXGQHJj2yo3AnkSE38CfKpauKtpP23yymMP+yuC4f+bV
1in6cVIp7MD756Wc/1kZ
=ozH9
-----END PGP SIGNATURE-----


Reply to: