Re: RFS: lastfmlib
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 05/01/2011 03:15 PM, Michael Tautschnig wrote:
> First of all: I have no idea where this "somewhere" is, and indeed I find that
> naming *of the source package* very strange. This naming requirement is true for
> the binary packages, however, and therefore I wonder whether you could just call
> those "liblastfm{1,-dev}"?
I thought about that myself, but didn't because the upstream package is
named lastfmlib (i believe there's another project named liblastfm..). I
renamed the source package, binaries unchanged for now...
>
> And there is more to be fixed:
>
> - lastfmlib/unittest/lastfmclientmock.h lacks both copyright and license
> information. Upstream must get that sorted out first.
I'll check with him..
> - I could not find any essential changes in debian-changes-0.4.0-1.
> - It would be desirable to enable the unittests at build time.
> - A selection of lintian messages to be addressed:
> I: liblastfmlib source: binary-control-field-duplicates-source field "section" in package liblastfmlib1
> I: liblastfmlib source: duplicate-short-description liblastfmlib-dev liblastfmlib1
> I: liblastfmlib source: duplicate-long-description liblastfmlib-dev liblastfmlib1
> W: liblastfmlib-dev: description-synopsis-starts-with-article
> W: liblastfmlib1: description-synopsis-starts-with-article
Updated package available in the collab-maint git repo, let me know if
you want me to upload to mentors instead.
Thanks for reviewing :)
Regards
Andreas Noteng
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBCAAGBQJNxFTGAAoJELRG7qgympRaYRMP/1j+05hnf1HfAwfk18R5o/gN
FdlKGbdwRl6S4wCVudloOEk9liQR4sgnU3DIVpkZeZb8EToPfHn7B2+c1T9H4yYB
qhyG0ifDNWYqFfo+ZhUTx+Y2vNSzkTGrhFSSFMiHMdmcc6Ge1eNnAqtEZ4xVPz6+
ENZCc+J4WZyeASy/1Qkwb4xsPkqY0MW5KD+8v9HxiJJFwRs2oUDV0HNktrUKB5Yg
e2sb4lYVjfZatRj7IF3+jG8dKOqL7ihl/BuCCZQlzwOH6tFKG7bPXyvRWp7CTLU3
4UMxtDsKH8XlVCUFFGcMXEKC6vH1OerHMCnSBFZfJ7HX9auBOES1yZdZxB51C+gK
O2EIDVsuNhCLeoShqWtDxTSm+9oQuE2cWR0FADZcPxA9LHVHoqD8GHvMZC+36SXu
B67dVGEepJPXUOuYc5/GGQLZmSxfbAS8ohHfkpGq/sZ0VqvgWaZ4X1nYXvsybcDn
JMB78IhyNmOds8iLigoTjQ5Rh/Z94IFE0EJbebntpu5A6JPykqpH/q0BZFE/Fn6O
zaIF0mw4I1m2QisnzXwFvafD2nlVBty5eQUtJm8ErKRKSP08Lj8ESXFiLA4pJNo+
l0ddxRKW/T3cBdmuJ64gXuzVW9ptvj95vn+DyJ3W/huJUbr6uJ01k9+XC6TylybC
8v1iLKC2Ub1rcR6MK3NH
=YYy/
-----END PGP SIGNATURE-----
Reply to: