Re: would like review of my polipo-tor packaging
On Mon, Jan 17, 2011 at 6:42 PM,
<travis+ml-debian-mentors@subspacefield.org> wrote:
> http://mentors.debian.net/cgi-bin/maintainer-packages?action=details;package=polipo-tor;seeksponsor=0
>
> Not asking for a sponsor right now since it depends on pkgs not in deb/ubu repos.
>
> But would like constructive criticism on packaging.
>
> Version upped to 1.4 with various minor packaging fixes.
> --
Hello- non-DD review. I haven't built it yet but there are some quick
cosmetic things to do first:
make sure your package is lintian clean (run "lintian --pedantic -I"
on your .changes file). I see some things it will tell you about:
Standards-Version: 3.8.4 should be 3.9.1
changelog should close an ITP bug [1,2]
Changelog should only have one entry (this is a new package in debian)
and should target unstable
Also
Copyright should be in DEP5 style [3] (it is in candidate stage now)
I haven't read the details of your package - it seems to install
configurations and sets up a log directory. I'm not familiar with
these packages, but is a separate package to set up this configuration
necessary - or is there a way you can include this functionality in
existing packages (or maybe add a new binary package to existing
packages instead of a new source package)?
Cheers,
Scott
[1] http://lintian.debian.org/tags/new-package-should-close-itp-bug.html
[2] http://www.debian.org/doc/developers-reference/pkgs.html#newpackage
[1] http://dep.debian.net/deps/dep5/
Reply to: