Re: RFS: ranger
Hi,
Vern Sun <s5unty@gmail.com> writes:
> ranger - a free console file manager
I don't know much about Python, so just some generic comments:
· Please file a ITP bug for new packages, for example with `reportbug
wnpp'.
· You don't need to build-depend on quilt when using the new source
format `3.0 (quilt)' (unless you use quilt elsewhere). Also don't use
`dh $@ --with quilt' with the new source format: dpkg-source will
handle the patches for you.
· debian/README.Debian: No need to include files without real content.
· debian/rules: Rules like
override_dh_auto_install:
dh_auto_install
do nothing: debhelper will call the override_dh_auto_install target
*instead* of dh_auto_install. So if you just call dh_auto_install
there, you can just remove the override_* target as well.
· debian/rules: `find | xargs rm -f' could probably be `find -delete'
or `find -execdir rm -f {} +' (both work with whitespace).
· debian/watch seems to be incorrect: uscan does not find any tarball
to download.
Regards,
Ansgar
Reply to: