Re: RFS: dvbackup
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hello Dmitry,
here is a quick (and incomplete) review:
* For both, QA and NMUs it is helpful to provide a diff of all changes.
You can use the debdiff tool, or provide a diff of the respective debian
directories at least outlining all your changes.
* As I mentioned before, you aren't doing a NMU but a QA upload. You set
the maintainer in debian/control correctly, but the version number is
wrong, as is the first line in debian/changelog. This would fix the
following Lintian warnings:
W: dvbackup source: qa-upload-has-incorrect-version-number 0.0.4rj1-6.2
W: dvbackup source: changelog-should-mention-qa
* When closing bugs in debian/changelog you should mention what you have
done and why [1]
* What's "debian/watch: updated (to help closing #449933)" supposed to
mean? Either you close a bug or you don't.
* It is no hard requirement, but if you're doing a QA upload and a
package has no public VCS yet, you may consider making one in collab-maint.
* You should not link the upstream homepage in the package description.
We have our own control field to link that. That would fix these Lintian
warnings [2]:
I: dvbackup: description-possibly-contains-homepage
http://dvbackup.sourceforge.net/
P: dvbackup: no-homepage-field
* Please rebuild the man page from source. Upstream contains both, a
docbook SGML file and its compiled nroff counterpart. However, it looks
like the last time this manpage was processed from its SGML source seems
to have been more than 10 years ago. That yields to these warnings a
modern docbook-to-man processor would fix:
I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/dvbackup.1.gz:131
I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/dvbackup.1.gz:134
I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/dvbackup.1.gz:135
I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/dvbackup.1.gz:143
I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/dvbackup.1.gz:147
I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/dvbackup.1.gz:148
I: dvbackup: hyphen-used-as-minus-sign usr/share/man/man1/rsbep.1.gz:141
While you're at it, you could also fix:
I: dvbackup: spelling-error-in-manpage usr/share/man/man1/rsbep.1.gz
completly completely
* You're installing HTML documentation but you are not registering the
file with doc-base [4]. No clue what's the correct cdbs way to achieve
that ...
However, that addresses this problem:
I: dvbackup: possible-documentation-but-no-doc-base-registration
[1]
http://www.debian.org/doc/manuals/developers-reference/pkgs.html#upload-bugfix
[2]
http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Homepage
[3]
http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-desc
[4] http://www.debian.org/doc/debian-policy/ch-opersys.html#s-doc-base
- --
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJO0ET4AAoJEMcrUe6dgPNt+6AP/j59GkOFYGvTzK9nU2JGrush
KaVAsVBzOWYzROfqKhEy2HZo+oGm28Np4lxfW0i6MYg65HBKfdkj5XE/5nN6MbFx
1rQpDZ7e35gmGihM/MA+vld7/L+J64cYZmk39QOTsli+IvOvTarnCB3ceHHdwHSx
/qZKpAiSVhBFtWh1IgZxMuc+zfIbQ9bQPAgLIso1OwvAn0Ek8EBvP8OA6Gz0P70O
TLGluGxaTSoS68o5DPmEK7N2rBkDk8R4jrU0KVKKDh+Vm/syc1yEo9Zv8apHU9S5
fJJsqjgxzPs6lTyCduQfb8nQ5T5Jbzspdwl5k2LWywzjwB+lg6jgkclTcLmKpTb4
9X/Izji01NKa3DjqLRrRTSUUfpDF+qAWNfxku/9WscZNGYu6sHPiEQUaT89PpnHB
1UaUrda90B/lBdavPggAj69CaO5th44dPJG+BOpWIk/gDDCQAX82hjgxcmfpXbZt
6Q4DNcTVoSHIoHgz+aVhuVNC/lScK6bEs/T3mMMd1CMGnoSKYAFRAtITq8ymP9iG
b2LA1CQOUpUMlH/rQvkw3WY9/9Po2vDz19bck5e5RzFcfoXIHm+ro0mwnM9Rb5U9
Ya0dBduFW0fVQcH2czFDHNmMH9ZzZe9kZD+IdkRWP6U6CXrvGUJPXZR4gOq7wjwj
ffw+6mkMlYObOAshVSvz
=WngY
-----END PGP SIGNATURE-----
Reply to: