Re: RFS: inadyn

[Benoît Knecht <benoit.knecht@fsfe.org>]

Hi Timur,

Timur Birsh wrote:
> I am looking for a sponsor for my package "inadyn".
> 
>  * Package name    : inadyn
>    Version         : 1.98.1-1
>    Upstream Author : Joachim Nilsson <troglobit@vmlinux.org>
>  * URL             : http://troglobit.com/inadyn.shtml
>  * License         : GPL-2+
>    Section         : net
> 
> It builds those binary packages:
> 
> inadyn     - Simple and small DynDNS client written in the C language

I had a quick look at your package; here are a few comments:

  - Lintian reports a few warnings:
      I: inadyn: debian-news-entry-uses-asterisk
      I: inadyn: hyphen-used-as-minus-sign usr/share/man/man5/inadyn.conf.5.gz:46
      I: inadyn: hyphen-used-as-minus-sign usr/share/man/man5/inadyn.conf.5.gz:48
      I: inadyn: hyphen-used-as-minus-sign usr/share/man/man5/inadyn.conf.5.gz:50
      I: inadyn: hyphen-used-as-minus-sign usr/share/man/man5/inadyn.conf.5.gz:52
      I: inadyn: hyphen-used-as-minus-sign usr/share/man/man5/inadyn.conf.5.gz:54

  - I don't think the short description should mention the language it's
    written in; something about supporting multiple accounts would be
    much more relevant here;

  - I don't get why the user/group created by the postinst script are
    prefixed with 'debian-'; none of the packages I have on my system do
    that;

  - The purge target in the postrm script should remove the user/group
    created during installation;

  - dpkg-shlibdeps gives this warning:
      dpkg-shlibdeps: warning: dependency on libresolv.so.2 could be avoided if "debian/inadyn/usr/bin/inadyn" were not uselessly linked against it (they use none of its symbols).

  - The host listed in the watch file seems to be down; is it temporary
    or did the package move to a new home?

  - In debian/copyright, the license of src/base64utils.c is not free.
    It allows that file to be used and distributed, but not modified. Is
    it possible to replace it with a free equivalent?

Cheers,

-- 
Benoît Knecht