Re: RFS: wmaker

[Paul Tagliamonte <paultag@ubuntu.com>]

INADD, but here's a review,

General note:
 - You've got a lot of stuff in ./debian/ - I would invite you to
consider creating a few directories to put files that relate to
eachother (theme related stuff, and so forth)

You're overriding a lot of stuff. Can you please explain them all?
Some of them look valid...

You should consider putting a comment block by each override, and note
exactly why. If lintian's in error, please report a bug (and don't
override!)

wmaker: menu-item-creates-new-root-section
wmaker: menu-command-not-in-package
wmaker: menu-item-contains-unknown-tag
wmaker: menu-item-needs-tag-has-unknown-value

./debian/debian.tiff.uu
 - You can avoid uuencoding with source format 3 (as you're using)

./debian/nightly_build.sh
 - what is this, and why do we need it in the archive? :)

./debian/TODO
 - Consider keeping track of this in the BTS

./debian/copyright
  You say:
    License: public-domain

    but then you go on to say:

     They may be distributed freely and/or modified as long as the original
     Author is mentioned!

    That's not public domain :)

  Also:
    License: public-domain
    do What The Fuck you want to Public License

  Lastly:
    you have a GPL-2 block without files.

./debian/rules
  I've never seen such a large dh-short rules file before.

  Consider some of the following:

    XLOCALE           := --disable-locale
    [snip]
    WMAKER_OPTIONS := $(XLOCALE) $(MODELOCK) $(XINERAMA) \
    [snip]

  You're going to have to modify this file anyway, why not keep a
well-formatted list of the args directly.

   There's more, but I think it just needs a good hard think on what
really needs to be in there.
   I mean, it's huge.

I didn't get a chance to get too much farther then this, I just ran
out of laptop battery. Someone else can take over - it looks like this
needs a good stern clean.

Other then that, it's in fairly nice shape. Well done on maintaining
such a huge package.

Overrides aside, lintian reports one source pedant:

P: wmaker source: unneeded-build-dep-on-quilt
N:
N:    This package build-depends on quilt, which is not required since
N:    dpkg-source will apply patches at unpack time for 3.0 (quilt) source
N:    packages.
N:
N:    Remember to remove any references to quilt in the rules file (e.g.
N:    "--with quilt", dh_quilt_* or quilt makefile includes).
N:
N:    This tag is meant to remind people that with 3.0 (quilt), quilt is not
N:    necessary. If you keep the build-depends on quilt to ease backporting to
N:    older releases, then please ignore/override this tag.
N:
N:    Severity: pedantic, Certainty: possible
N:
N:    Check: patch-systems, Type: source
N:

Have a super great day,
Paul



-- 
All programmers are playwrights, and all computers are lousy actors.

#define sizeof(x) rand()
:wq