[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: django-autoslug


Thanks Jakub for your helpful advice, I took the time to fix the points you mentioned and re-uploaded the package to debexpo.

For future, debian-python@lists.debian.org might a better place to ask for sponsorship of packages like this.
Ok, I will, is that ok if I stay on debian-mentors for that first package ?

According to Python Policy 2.2, the binary package name should be python-autoslug. (Now, you may say that's too generic and that the package name should include "django" - but so should upstream module name...)
Yes, I do believe that django-requiring modules should stick in django namespace. Anyway, it's never the case but all debian packages I saw are named python-django-*, which is quite usefull for the user.

- Remove XB-Python-Version, it servers no purpose.
- More importantly, remove "Provides: ${python:Provides}". See <http://lists.debian.org/debian-python/2011/03/msg00139.html> for rationale. - Short description is not a sentence, so it should not end with a dot. See Developer's Reference 6.2.2.

- It doesn't make sense. You package was never affected by #479852 (besides, the bug is already fixed in stable).

- Please consider removing useless comments.
- Unexporting anything is not necessary, the *FLAGS don't affect your package by any means.

- Please write one. That shouldn't be hard, as the tarballs are available at PyPI.

- So is it 1.3.5 or 1.4.1 after all?

It's definitely 1.4.1. By the way, I noticed that the actual home is https://bitbucket.org/neithere/django-autoslug/ , I changed that in the debian/control and debian/copyright too. So the actual latest version from bitbucket doesn't have that confusing _version.py file.

- Please run them at build time.
done (needed to add python-all to build-depends).

I see two lines errors on in "QA" section of http://mentors.debian.net/package/django-autoslug :

Error: /home/expo/data/live/incoming/django-autoslug_1.4.1-1_amd64.changes
Error: 	django-autoslug_1.4.1-1.dsc

What do they mean ?

Do you see any other issues with this package ?

Cheers, and thanks again :)

  Jocelyn Delalande

Blog (fr) http://hackriculture.fr
Home      http://crapouillou.net/~jocelyn
IRC       JocelynD /OFTC

Reply to: